Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating largo_byline call in partials #1574

Merged
merged 3 commits into from
Nov 15, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Special thanks to our community contributors:

### Upgrade notices
- If your child theme has significant custom styling, or has custom post templates, your theme may need to provide additional styles to ensure Gutenberg compatibility.
- A future version of Largo will require the third parameter of `largo_byline()` to be specified in all calls. [PR #1561](https:/INN/largo/pull/1561) for [issue #1517](https:/INN/largo/issues/1517) adds code that, in testing environments with `WP_DEBUG` or `LARGO_DEBUG` set to `true`, will result in server log messages. This is necessary to prevent mismatches between the Loop's global `$post` and the desired byline output. The third parameter of `largo_byline()` may be a `WP_Post` instance or a post ID. Example call: `largo_byline( null, null, get_the_ID() );`.
- A future version of Largo will require the third parameter of `largo_byline()` to be specified in all calls. [PR #1561](https:/INN/largo/pull/1561) for [issue #1517](https:/INN/largo/issues/1517) adds code that, in testing environments with `WP_DEBUG` or `LARGO_DEBUG` set to `true`, will result in server log messages. This is necessary to prevent mismatches between the Loop's global `$post` and the desired byline output. The third parameter of `largo_byline()` may be a `WP_Post` instance or a post ID. Example call: `largo_byline( true, false, get_the_ID() );`.

## [Largo 0.5.5.4](https:/INN/largo/releases/tag/v0.5.5.4)

Expand Down
2 changes: 1 addition & 1 deletion homepages/templates/top-stories.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
?>
<a href="<?php the_permalink(); ?>"><?php the_post_thumbnail( 'large' ); ?></a>
<h2><a href="<?php the_permalink(); ?>"><?php the_title(); ?></a></h2>
<h5 class="byline"><?php largo_byline( null, null, get_the_ID() ); ?></h5>
<h5 class="byline"><?php largo_byline( true, false, get_the_ID() ); ?></h5>
<?php largo_excerpt( $post, 4 ); ?>
<?php if ( largo_post_in_series() ):
$feature = largo_get_the_main_feature();
Expand Down
2 changes: 1 addition & 1 deletion partials/content-roundup.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<a href="<?php the_permalink(); ?>" title="<?php the_title_attribute( array( 'before' => __( 'Permalink to', 'largo' ) . ' ' ) )?>" rel="bookmark"><?php the_title(); ?></a>
</h2>

<h5 class="byline visuallyhidden"><?php largo_byline( null, null, get_the_ID() ); ?></h5>
<h5 class="byline visuallyhidden"><?php largo_byline( true, false, get_the_ID() ); ?></h5>

<?php the_content(); ?>

Expand Down
2 changes: 1 addition & 1 deletion partials/content-single-classic.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<?php if ( $subtitle = get_post_meta( $post->ID, 'subtitle', true ) )
echo '<h2 class="subtitle">' . $subtitle . '</h2>';
?>
<h5 class="byline"><?php largo_byline( null, null, get_the_ID() ); ?></h5>
<h5 class="byline"><?php largo_byline( true, false, get_the_ID() ); ?></h5>

<?php
if ( !of_get_option( 'single_social_icons' ) == false ) {
Expand Down
2 changes: 1 addition & 1 deletion partials/content-single.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<?php if ( $subtitle = get_post_meta( $post->ID, 'subtitle', true ) ) : ?>
<h2 class="subtitle"><?php echo $subtitle ?></h2>
<?php endif; ?>
<h5 class="byline"><?php largo_byline( null, null, get_the_ID() ); ?></h5>
<h5 class="byline"><?php largo_byline( true, false, get_the_ID() ); ?></h5>

<?php if ( ! of_get_option( 'single_social_icons' ) == false ) {
largo_post_social_links();
Expand Down
2 changes: 1 addition & 1 deletion partials/content.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@

<?php
if ( $show_byline ) { ?>
<h5 class="byline"><?php largo_byline( null, null, get_the_ID() ); ?></h5>
<h5 class="byline"><?php largo_byline( true, false, get_the_ID() ); ?></h5>
<?php }
?>

Expand Down
2 changes: 1 addition & 1 deletion partials/sticky-posts.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
<?php } ?>

<h2 class="entry-title"><a href="<?php the_permalink(); ?>"><?php the_title(); ?></a></h2>
<h5 class="byline"><?php largo_byline( null, null, get_the_ID() ); ?></h5>
<h5 class="byline"><?php largo_byline( true, false, get_the_ID() ); ?></h5>

<div class="entry-content">
<?php
Expand Down
2 changes: 1 addition & 1 deletion series-landing.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<h1 class="entry-title"><?php the_title(); ?></h1>
<?php
if ( $opt['show_series_byline'] )
echo '<h5 class="byline">' . largo_byline( false, null, get_the_ID() ) . '</h5>';
echo '<h5 class="byline">' . largo_byline( false, false, get_the_ID() ) . '</h5>';
if ( $opt['show_sharebar'] )
largo_post_social_links();
?>
Expand Down