-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug on attachement when updating to cucumberjs 10+ #298
Comments
Hello, the pull request has not yet been accepted, any feedback to resolve the problem? |
Hi @charleslana , the PR has a failing test. Once it gets fixed, we are good to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment (please complete the following information):
Describe the bug
In the JSON formatter output of multiple-cucumber-html-reporter, all attachments, including those initially attached as plain text strings, are now Base64 encoded. This uniform encoding approach leads to ambiguity for consumers of the report, as they cannot distinguish whether an attachment was originally a plain text string or a different file format.
To Reproduce
Steps to reproduce the behavior:
just generate a report based on cucumber 10.0.1 with some attachement (json/ text / image)
Expected behavior
The expected behavior was that string attachments would remain as plain text in the JSON formatter output, while other types of attachments would be Base64 encoded. This distinction would enable consumers to easily identify the nature of the attachments without additional processing.
Additional context
To resolve this issue, a decoding mechanism such as atob(embedding.data); should be implemented to correctly decode Base64 attachments before passing them to the report. This would ensure that plain text attachments maintain their original format in the JSON output.
The text was updated successfully, but these errors were encountered: