Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Fill and Crop" option for wf-background. Pt 2 #226

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Add "Fill and Crop" option for wf-background. Pt 2 #226

merged 7 commits into from
Apr 3, 2024

Conversation

trigg
Copy link
Contributor

@trigg trigg commented Apr 2, 2024

I felt strongly about #58 so I replicated the fork against master and followed the requested changes.

After some testing with a variety of images and screens I made further edits:

  • Added an image_scale value that gets passed into the render logic for each image
  • Added cairo context save/restore and placed a scale inside it to allow the image to be scaled up in-place without loading it a second time.

These were necessary as loading tall images in ultrawide screens or visa-versa caused a crash from attempting to create a Pixbuf that was too large.

I have attempted to stick to the coding style of the project but feel free to correct me on it.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work, thanks!

@ammen99 ammen99 merged commit 7841a49 into WayfireWM:master Apr 3, 2024
2 checks passed
@ammen99 ammen99 mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants