Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window-list: attach popup menu to button #246

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

trigg
Copy link
Contributor

@trigg trigg commented Apr 21, 2024

No description provided.

@trigg
Copy link
Contributor Author

trigg commented Apr 21, 2024

Aligns edge of popup to edge of the button, orientation is corrected by Gtk by default if top/bottom is selected

@ammen99
Copy link
Member

ammen99 commented Apr 25, 2024

So this changes the position of the menu popup, a question at people who use this menu (@soreau? and probably others) which one do you prefer:

  • New layout:
    slurped

  • Old layout:
    slurped

I.e should the menu be centered on where the user clicked (which is somewhere in the middle of the button) or below the button.

@ammen99 ammen99 requested a review from soreau April 25, 2024 07:42
@trigg
Copy link
Contributor Author

trigg commented Apr 25, 2024

2024_04_25_08_46_09
And one with a bit more space on the list

@trigg
Copy link
Contributor Author

trigg commented Apr 26, 2024

For reference, I feel this is correct as it matches clock, menu & (more recently) tray.

@ammen99
Copy link
Member

ammen99 commented Apr 27, 2024

Thanks!

@ammen99 ammen99 merged commit 056c381 into WayfireWM:master Apr 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants