New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuff definition is not correct #261

Open

gsi-viera opened this issue Jun 11, 2024 · 1 comment · May be fixed by #294

gsi-viera commented Jun 11, 2024

https:/WerWolv/ImHex-Patterns/blob/3416d30f2b8fac4f12bf73aa1f5d5102a07b7f83/patterns/protobuf.hexpat#L34C5-L37C4

The specification for protobuff states that this record is Varint Encoded.

So it means that it's not guaranteed to have 8 bits. If the field index has its last significant bit on 1 then another byte has to be read.

I've tested this in real life payloads and I've confirmed that it's failing.

gsi-viera changed the title ~~Protobuff defintion is not correct~~ Protobuff definition is not correct

Contributor

applecuckoo commented Jul 25, 2024

This issue should probably be closed since it's a dupe of #152, which describes the exact same problem.

applecuckoo linked a pull request

that will close this issue

quick readme fix + new WebP and VGM patterns #294

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment