Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heroku #44

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Heroku #44

wants to merge 12 commits into from

Conversation

WesleyTheGeolien
Copy link
Owner

Branch that deploys to heroku https://t20-dash-well-viz.herokuapp.com/

@WesleyTheGeolien
Copy link
Owner Author

@kinverarity1 I had to modify the setup.py, tbh I don't use them too often it would be good if you could check out the 2 lines I deleted and see if they are necessary or not for other things?

@WesleyTheGeolien WesleyTheGeolien linked an issue Jun 13, 2020 that may be closed by this pull request
Deploy our app(s) to the cloud for demo #39
Closed
@kinverarity1
Copy link
Collaborator

kinverarity1 commented Jun 13, 2020 •
edited
Loading

Did the pre-existing setup.py break the heroku deployment? They are both relatively "new" additions to setuptools. So I can revert it back to older ways of handling the packaging, not a big deal.

@WesleyTheGeolien WesleyTheGeolien temporarily deployed to t20-dash-well-viz June 14, 2020 09:48 Inactive
WesleyTheGeolien
WesleyTheGeolien commented Jun 14, 2020
View reviewed changes
Copy link
Owner Author

@WesleyTheGeolien WesleyTheGeolien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the pre-existing setup.py break the heroku deployment? They are both relatively "new" additions to setuptools. So I can revert it back to older ways of handling the packaging, not a big deal.

@kinverarity1 Yep, but the version of setup.py in this branch works, does this setup seem reasonable to you? or do things need to be changed?

setup.py Outdated
setup_requires=["setuptools_scm"],
description="Tools for Transform 2020 Dash_Well_Viz project",
long_description=open("README.md", "r").read(),
long_description_content_type="text/markdown",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was just a warning @kinverarity1

setup.py Outdated
@@ -2,11 +2,9 @@

setup(
name="dashwellviz",
use_scm_version=True,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this was the line breaking the heroku builds @kinverarity1

@kinverarity1
Copy link
Collaborator

kinverarity1 commented Jun 14, 2020 via email

@WesleyTheGeolien
Copy link
Owner Author

Hmm maybe it's the runtime then if you say it is new? This is using python 3.6.10 do you think upgrading to 3.8 would help?

@kinverarity1
Copy link
Collaborator

kinverarity1 commented Jun 14, 2020 via email

@WesleyTheGeolien WesleyTheGeolien temporarily deployed to t20-dash-well-viz June 14, 2020 18:51 Inactive
@WesleyTheGeolien
Copy link
Owner Author

@kinverarity1 I have tried updating the runtime to python 3.8.3 and reintroducing the lines I removed. As suspected the long_description_content_type worked fine but the use_scm_version broke the deploy .... here is the log if it makes sense to you:


-----> Python app detected

-----> No change in requirements detected, installing from cache

-----> Installing SQLite3

-----> Installing requirements with pip

       Obtaining file:///tmp/build_20a9a9147a4c3fe45eaa36792e22ea85 (from -r /tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/requirements.txt (line 5))

           ERROR: Command errored out with exit status 1:

            command: /app/.heroku/python/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/setup.py'"'"'; __file__='"'"'/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info

                cwd: /tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/

           Complete output (27 lines):

           /app/.heroku/python/lib/python3.8/distutils/dist.py:274: UserWarning: Unknown distribution option: 'long_description_content_type'

             warnings.warn(msg)

           Traceback (most recent call last):

             File "<string>", line 1, in <module>

             File "/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/setup.py", line 3, in <module>

               setup(

             File "/app/.heroku/python/lib/python3.8/site-packages/setuptools/__init__.py", line 129, in setup

               return distutils.core.setup(**attrs)

             File "/app/.heroku/python/lib/python3.8/distutils/core.py", line 108, in setup

               _setup_distribution = dist = klass(attrs)

             File "/app/.heroku/python/lib/python3.8/site-packages/setuptools/dist.py", line 372, in __init__

               _Distribution.__init__(self, attrs)

             File "/app/.heroku/python/lib/python3.8/distutils/dist.py", line 292, in __init__

               self.finalize_options()

             File "/app/.heroku/python/lib/python3.8/site-packages/setuptools/dist.py", line 528, in finalize_options

               ep.load()(self, ep.name, value)

             File "/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/.eggs/setuptools_scm-4.1.2-py3.8.egg/setuptools_scm/integration.py", line 17, in version_keyword

               dist.metadata.version = _get_version(config)

             File "/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/.eggs/setuptools_scm-4.1.2-py3.8.egg/setuptools_scm/__init__.py", line 148, in _get_version

               parsed_version = _do_parse(config)

             File "/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/.eggs/setuptools_scm-4.1.2-py3.8.egg/setuptools_scm/__init__.py", line 110, in _do_parse

               raise LookupError(

           LookupError: setuptools-scm was unable to detect version for '/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85'.

           

           Make sure you're either building from a fully intact git repository or PyPI tarballs. Most other sources (such as GitHub's tarballs, a git checkout without the .git folder) don't contain the necessary metadata and will not work.

           

           For example, if you're using pip, instead of https:/user/proj/archive/master.zip use git+https:/user/proj.git#egg=proj

           ----------------------------------------

       ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

 !     Push rejected, failed to compile Python app.

 !     Push failed```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinverarity1 kinverarity1 Awaiting requested review from kinverarity1

@mharty3 mharty3 Awaiting requested review from mharty3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy our app(s) to the cloud for demo
2 participants
@WesleyTheGeolien @kinverarity1