Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed conflicts for experimental branch PR #139

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mrceresa
Copy link

@mrceresa mrceresa commented Apr 20, 2022

Dear friends,
thanks a lot for this beautiful package!

I was interested in the experimental branch features that is discussed here in #85 and in #91 but there were some conflicts due to the time that passed between the two branches. I tried to reconcile them and now they could be merged.

I run all the tests and they pass and I was also able to run all the cells in the example notebook. Also the utils.js library now loads correctly in the browser.

I'm not sure if I was able to import all the features but at least it highlight the nodes and show the selection menu.

Once I select the nodes the color of the others stays grey and do not reset.

Best,

Mario

@jhunpingco
Copy link
Contributor

Can you add some test cases and a Jupyter notebook for this so I can see the changes?

@mrceresa
Copy link
Author

Dear Jose,
this is simply a fix of the merge errors of the other PR, named "Experimental".

You can find a notebook here, but it is the same as the other, cheers

Mario

ExampleSelection.zip
pyvis_experimental_selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants