Do not load external bootstrap resources for cdn_resources = 'in_line' | 'local' #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cdn_resources
option should control how external resources and stylesheets should be loaded.Currently bootstrap is being fetched from CDN irrespective of the
cdn_resources
option.Also I have observed some inconsistencies in the
local
option where thevis-network
css and js files are not being taken from thelib
folder but rather externally fetched. Please correct me here if my understanding of how these options are intended to work is wrong.To summarise the changes:
cdn_resources = 'remote'
lib/
whencdn_resources = 'local'
example.ipynb
to update the samples