-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a rule to warn against invalid methods on component interfaces #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 89.45% 89.33% -0.13%
==========================================
Files 20 21 +1
Lines 683 722 +39
Branches 72 80 +8
==========================================
+ Hits 611 645 +34
- Misses 49 50 +1
- Partials 23 27 +4 ☔ View full report in Codecov by Sentry. |
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
2 times, most recently
from
April 6, 2024 15:28
b889907
to
fb6ea68
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
2 times, most recently
from
April 20, 2024 13:13
26de6a3
to
2709f8f
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
from
April 27, 2024 19:58
2709f8f
to
377a2b9
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
2 times, most recently
from
June 1, 2024 03:28
d69252a
to
3602492
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
2 times, most recently
from
June 14, 2024 01:52
5336201
to
ce1aef4
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
3 times, most recently
from
July 13, 2024 14:31
330dbf9
to
aca98bf
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
from
July 28, 2024 12:45
aca98bf
to
def9171
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
from
August 25, 2024 15:57
def9171
to
93b17b2
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
5 times, most recently
from
September 12, 2024 22:48
9214920
to
7b4399d
Compare
WhosNickDoglio
commented
Sep 12, 2024
WhosNickDoglio
commented
Sep 12, 2024
lint/dagger/src/main/java/dev/whosnickdoglio/dagger/detectors/ValidComponentMethodDetector.kt
Outdated
Show resolved
Hide resolved
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
2 times, most recently
from
September 13, 2024 14:25
522b21b
to
a390973
Compare
WhosNickDoglio
force-pushed
the
feature/ndoglio/valid-component-methods
branch
from
September 13, 2024 16:13
a390973
to
6157edb
Compare
WhosNickDoglio
added a commit
that referenced
this pull request
Sep 13, 2024
) <!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the style guidelines of this project (`./gradlew lint spotlessCheck`) - [ ] I have performed a self-review of my own code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules - [ ] I have checked my code and corrected any misspellings - [ ] I have mentioned changes in [CHANGELOG.md](../CHANGELOG.md). - [ ] I have read the [**CONTRIBUTING**](CONTRIBUTING.md) document. <!-- branch-stack --> - `main` - \#172 :point\_left:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
./gradlew lint spotlessCheck
)main