Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rule to warn against invalid methods on component interfaces #172

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

WhosNickDoglio
Copy link
Owner

@WhosNickDoglio WhosNickDoglio commented Jan 3, 2024

Description

Related Issue

Checklist

  • My code follows the style guidelines of this project (./gradlew lint spotlessCheck)
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.33%. Comparing base (ccb4cea) to head (6157edb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...o/dagger/detectors/ValidComponentMethodDetector.kt 89.47% 0 Missing and 4 partials ⚠️
.../whosnickdoglio/dagger/DaggerRulesIssueRegistry.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   89.45%   89.33%   -0.13%     
==========================================
  Files          20       21       +1     
  Lines         683      722      +39     
  Branches       72       80       +8     
==========================================
+ Hits          611      645      +34     
- Misses         49       50       +1     
- Partials       23       27       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch 2 times, most recently from b889907 to fb6ea68 Compare April 6, 2024 15:28
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch 2 times, most recently from 26de6a3 to 2709f8f Compare April 20, 2024 13:13
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch from 2709f8f to 377a2b9 Compare April 27, 2024 19:58
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch 2 times, most recently from d69252a to 3602492 Compare June 1, 2024 03:28
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch 2 times, most recently from 5336201 to ce1aef4 Compare June 14, 2024 01:52
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch 3 times, most recently from 330dbf9 to aca98bf Compare July 13, 2024 14:31
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch from aca98bf to def9171 Compare July 28, 2024 12:45
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch from def9171 to 93b17b2 Compare August 25, 2024 15:57
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch 5 times, most recently from 9214920 to 7b4399d Compare September 12, 2024 22:48
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch 2 times, most recently from 522b21b to a390973 Compare September 13, 2024 14:25
@WhosNickDoglio WhosNickDoglio marked this pull request as ready for review September 13, 2024 14:35
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/valid-component-methods branch from a390973 to 6157edb Compare September 13, 2024 16:13
@WhosNickDoglio WhosNickDoglio merged commit b68af58 into main Sep 13, 2024
11 of 13 checks passed
@WhosNickDoglio WhosNickDoglio deleted the feature/ndoglio/valid-component-methods branch September 13, 2024 16:26
WhosNickDoglio added a commit that referenced this pull request Sep 13, 2024
)

<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue

<!--- This project only accepts pull requests related to open issues -->

<!--- If suggesting a new feature or change, please discuss it in an
issue first -->

<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->

<!--- Please link to the issue here: -->

## Checklist

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->

<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] My code follows the style guidelines of this project (`./gradlew
lint spotlessCheck`)
- [ ] I have performed a self-review of my own code
- [ ] I have commented on my code, particularly in hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
- [ ] I have checked my code and corrected any misspellings
- [ ] I have mentioned changes in [CHANGELOG.md](../CHANGELOG.md).
- [ ] I have read the [**CONTRIBUTING**](CONTRIBUTING.md) document.

<!-- branch-stack -->

- `main`
  - \#172 :point\_left:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant