This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
Fix curl's version verification #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went awfully wrong ; we need to change to constant only if we have a version __below__ (and not __below *or equal*__), and while we're at it, divide the timeout by 1000 rather than multiplying it by 1000. We want seconds, not nanoseconds !
|
Don't understand your condition. You seem to only check a specific version against all the others (did not check version compare function though ) |
|
I'm only checking if the curl version is greater than the proposed one, which implements the (connect) timeout in ms. So, if we have a version below 7.16.2 ( Gotta fix it again then (getting fucking lost with all these -1, 0, 1) |
|
Much better like this. :) |
|
Great. Could you merge, tag accordingly and update the new version in our Wisembly project ? Thx |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops, something went awfully wrong ; we need to change to constant only if we have a version below (and not below or equal), and while we're at it, divide the timeout by 1000 rather than multiplying it by 1000. We want seconds, not nanoseconds !