This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
Fix Client read() function... #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With some tests, it seems that bin2hex is reproducing some strange results : <?php
const VALUE = 42;
var_dump(decbin(42)); // expected : 101010
var_dump(0b101010); // expected : 42But, if we check the doc for I'll keep your PR around and get a look at it when I'll get the chance to :) |
| $length = (int) (bin2hex($part) & ~0x80); // removing the mask bit | ||
| $mask = (bool) (bin2hex($part) & 0x80); | ||
| $mask = hexdec((bin2hex($part) & 0x80)) == 1; | ||
| $length = hexdec(bin2hex($part)); // Working... |
There was a problem hiding this comment.
this length here has the mask bit, does it not ? Shouldn't it get a wrong result if the mask bit is 1 ?
|
Seems that #106 solved it, with a fix similar to yours... closing I guess. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to allow to read small message sent by the server
Okay, to be clear, I'm not proud of this pull request. This is clearly NOT the best way to do it, but it works...
The (int) and (bool) cast wasn't working for me and I don't know why. The more disapointing was the bindec function... I was supposing that hexdec(bin2hex()) = bindec() but it wasn't...
This code is ugly, but it works. Maybe this could inspire Taluu to do his magic stuff on it.