Block Bindings: Bootstrap server sources earlier #66058
Open
+31
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
SantosGuillamot
requested review from
gziolo,
ryanwelcher,
artemiomorales and
cbravobernal
SantosGuillamot
requested review from
spacedmonkey,
draganescu,
adamziel and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -213 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Tests are failing, it seems that now requires to not set a label here: gutenberg/packages/e2e-tests/plugins/block-bindings/index.js Lines 20 to 26 in fe88860 |
SantosGuillamot
requested review from
ntwb,
nerrad and
ajitbohra
as code owners
|
That makes sense. I just pushed a commit to change that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66031
In this pull request, I'm proposing removing the existing way of bootstrapping the sources defined in the server and do it directly in core with an inline script.
Why?
In the current implementation, bootstrapping happens in
initializeEditor, which happens after dom ready. This means that when a external source is registered in the server and in the client, the bootstrap happens too late, causing unexpected behaviors.How?
I removed the existing logic and added a filter to add an inline script registering the server sources. This will be replicated in core.
Testing Instructions
e2e should pass.
The issue reported here should be fixed.