-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Afternoon: List of elements to adjust #538
Comments
Is it intentional the H4 and H5 should be identical? I am not sure that is ideal. |
Yes, it is intentional. I assumed we'd prefer to use font size presets in the headings. |
I wish I could get 100 likes on WordPress/gutenberg#65108 |
@carolinan @beafialho I just submitted PR #564 to fix some of the items in the original list
Items that I'm not sure how or where to address (apologies, just learning block themes, I've only used some of their features in hybrid themes so far, so TT5 to me is a whole new experience)
Question about the following:
In the primary Happy to fix anything i missed with some feedback, just point me in the right direction and I'm on it :) |
Looks like this has a partial PR so will focus over there. |
I have added a series of screenshots for all the changes I have made, as well as adding additional comments and screenshots to for additional work. Unless I missed or misunderstood something, this should be a completed PR now. |
Closed as completed via #564 |
While testing Afternoon variation and its typography preset, I noticed some size issues that make it look bad.
I tried to edit the files myself but the chance of messing them up was high, so I tried my best to enumerate the following changes I made in Global Styles in the editor, which I kindly ask be taken to a PR.
2rem
, max2.6rem
1.4rem
,1.8rem
font-weight: 300
, line height to1,5
font-weight: 400
, letterSpacing: -0,1px , line-height: 1.2400
same as others)Here's how it's supposed to look with these changes:
cc: @juanfra @carolinan @richtabor
The text was updated successfully, but these errors were encountered: