Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afternoon: List of elements to adjust #538

Closed
beafialho opened this issue Oct 9, 2024 · 7 comments
Closed

Afternoon: List of elements to adjust #538

beafialho opened this issue Oct 9, 2024 · 7 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@beafialho
Copy link
Contributor

beafialho commented Oct 9, 2024

While testing Afternoon variation and its typography preset, I noticed some size issues that make it look bad.

Image

I tried to edit the files myself but the chance of messing them up was high, so I tried my best to enumerate the following changes I made in Global Styles in the editor, which I kindly ask be taken to a PR.

  • Change font preset XXL: min 2rem, max 2.6rem
  • Change font preset XL: min 1.4rem, 1.8rem
  • Text: set to font-weight: 300, line height to 1,5
  • Headings: set to font-weight: 400, letterSpacing: -0,1px , line-height: 1.2
  • H1: XXL font size
  • H2: XL font size
  • H3: L font size
  • H4: M font size
  • H5: M font size
  • H6: S font size + (remove uppercase, letter spacing, remove specific font weight, it should be 400 same as others)
  • Site Title: set to Large font size
  • Post author, post author name, post date, post terms: remove font size preset added globally
  • Titles (Post Titles): any specific settings should be removed, they should inherit the headings settings

Here's how it's supposed to look with these changes:

Image
Image
Image
Image
Image

cc: @juanfra @carolinan @richtabor

@beafialho beafialho added the [Type] Enhancement A suggestion for improvement. label Oct 9, 2024
@carolinan
Copy link
Contributor

Is it intentional the H4 and H5 should be identical? I am not sure that is ideal.

@beafialho
Copy link
Contributor Author

Yes, it is intentional. I assumed we'd prefer to use font size presets in the headings.

@carolinan
Copy link
Contributor

carolinan commented Oct 10, 2024

I wish I could get 100 likes on WordPress/gutenberg#65108

@troychaplin
Copy link
Contributor

troychaplin commented Oct 11, 2024

@carolinan @beafialho I just submitted PR #564 to fix some of the items in the original list

Change font preset XXL: min 2rem, max 2.6rem
Change font preset XL: min 1.4rem, 1.8rem
Text: set to font-weight: 300, line height to 1,5
Headings: set to font-weight: 400, letterSpacing: -0,1px , line-height: 1.2
Site Title: set to Large font size
Titles (Post Titles): any specific settings should be removed, they should inherit the headings settings

Items that I'm not sure how or where to address (apologies, just learning block themes, I've only used some of their features in hybrid themes so far, so TT5 to me is a whole new experience)

H1: XXL font size
H2: XL font size
H3: L font size
H4: M font size
H5: M font size
H6: S font size + (remove uppercase, letter spacing, remove specific font weight, it should be 400 same as others)

Question about the following:

Post author, post author name, post date, post terms: remove font size preset added globally

In the primary 04-afternoon.json I see core/post-author, core/post-author-biography and core/post-author-name and each of them have "fontSize": "var:preset|font-size|medium". Is this what needs to be removed, or is that done elsewhere?

Happy to fix anything i missed with some feedback, just point me in the right direction and I'm on it :)

@karmatosed karmatosed self-assigned this Oct 13, 2024
@karmatosed
Copy link
Member

karmatosed commented Oct 13, 2024

Looks like this has a partial PR so will focus over there.

@karmatosed karmatosed removed their assignment Oct 13, 2024
@troychaplin
Copy link
Contributor

Looks like this has a partial PR so will focus over there.

I have added a series of screenshots for all the changes I have made, as well as adding additional comments and screenshots to for additional work. Unless I missed or misunderstood something, this should be a completed PR now.

@juanfra
Copy link
Member

juanfra commented Oct 14, 2024

Closed as completed via #564

@juanfra juanfra closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants