Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Update noon & typography preset 1. #562

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Try: Update noon & typography preset 1. #562

merged 5 commits into from
Oct 14, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 11, 2024

Description

Fixes #547

Updating the style variation and typography preset according to the request here

Screenshots

  • N/A

Testing Instructions

  1. Go to the site editor
  2. Pick the "Beiruti & Literata" typographic preset and confirm the styles match the ones listed in the issue.

  1. Go to the site editor
  2. Pick the "Noon" style variation and confirm the styles match the ones listed in the issue.

@juanfra juanfra self-assigned this Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra
Copy link
Member Author

juanfra commented Oct 14, 2024

Thank you Carolina!

@carolinan
Copy link
Contributor

  • Reset Post Author styles

  • Reset Post Date styles

  • Post Terms: reset font and font size

  • Reset Post Titles typography styles

  • Text: set letter spacing -0.01em and line height 1,6

  • All Headings: set letter spacing -0.02em , line height 1,02

  • [inherits] H3: set to L font size

  • H5: remove custom letter spacing

  • Assumed XXL Text preset size XL: min 2rem, max 2.8rem

  • Text preset size XL: min 1.8rem, max 2.2rem

  • Text preset size L: min 1.6rem, max 1.8rem

  • Text preset size Medium: min 1rem, max 1.2 rem

  • Quote: remove line height (it should be the same as text)

@beafialho
Copy link
Contributor

Thanks @juanfra!

The only thing I'm seeing differently than expected is the quote:

What I'm seeing What it's expected to look like
Captura de ecrã 2024-10-14, às 11 38 41 375330552-8c4c7a9e-0b46-4409-8d3f-3cf150b0294d

@beafialho
Copy link
Contributor

Thank you @juanfra, the quote is looking good now 👍

@juanfra
Copy link
Member Author

juanfra commented Oct 14, 2024

Thank you! Merging this one.

@juanfra juanfra merged commit 9ce5623 into trunk Oct 14, 2024
4 checks passed
@juanfra juanfra deleted the update/noon branch October 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noon: List of elements to adjust
3 participants