Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the viewport width of the vertical header #575

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

carolinan
Copy link
Contributor

Description
In the header and pattern previews in the Site Editor, the vertical header is very small.
The CSS transform that is used on the pattern preview also animates the pattern which makes it look like it moves from the top to bottom.

This pull request adds a viewport width to the vertical header pattern, which makes the preview zoom in on the design closer.
It also reduces the impact of the animation.

Screenshots
In these videos I am refreshing the Patterns data view screen in the Site Editor.

Before:

vertical-header.mp4

After:

vertical-header-after.mp4

Testing Instructions
Go to Appearance > Editor > Patterns > Headers
Confirm that the vertical header is more visible than before.

@carolinan carolinan added the [Type] Enhancement A suggestion for improvement. label Oct 15, 2024
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor Author

Note: the vertical header template part still shows the small pattern preview.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried following the steps described and I couldn't get it working.

Screen.Recording.2024-10-15.at.11.17.20.mov

Not sure if I missed any step?

@carolinan
Copy link
Contributor Author

carolinan commented Oct 15, 2024

Select the header pattern, not the parts. The parts are not using the viewport widths, those are the HTML files.

@carolinan
Copy link
Contributor Author

WordPress/gutenberg#66111

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, I see the changes now. Works well.

Screen.Recording.2024-10-15.at.11.36.35.mov

@juanfra juanfra merged commit 14c4353 into trunk Oct 15, 2024
6 checks passed
@juanfra juanfra deleted the update/header-viewport-width branch October 15, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants