Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate values #118

Merged
merged 4 commits into from
Dec 16, 2015
Merged

Remove duplicate values #118

merged 4 commits into from
Dec 16, 2015

Conversation

dustinhiatt-wf
Copy link
Contributor

This PR does two things:

  1. Removes redundant information that was on the nodes and instead relies on calling interval methods. This reduces performance and memory consumption and means there is less state to track.
  2. Kills the insert method. All intervals are assumed to be immutable. To insert, the consumer should query for all affected ranges, delete them, mutate them, and re-insert them. This will also more closely mimic how this operation would be performed in an R-Tree.

@alexandercampbell-wf @rosshendrickson-wf @ericolson-wf @seanstrickland-wf @matthinrichsen-wf @wesleybalvanz-wf @blakewilson-wf

@dustinhiatt-wf
Copy link
Contributor Author

CI is fixed with: #119

@alexandercampbell-wk
Copy link
Contributor

+1, I really like this change

@johnryan-wf
Copy link

+1

@alexandercampbell-wk
Copy link
Contributor

@dustinhiatt-wf ready to merge

dustinhiatt-wf added a commit that referenced this pull request Dec 16, 2015
@dustinhiatt-wf dustinhiatt-wf merged commit 9f819b6 into master Dec 16, 2015
@alexandercampbell-wk alexandercampbell-wk deleted the remove_duplicate_values branch December 16, 2015 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants