Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Feature/default dict package #46

Merged
merged 19 commits into from
Jul 7, 2019
Merged

Feature/default dict package #46

merged 19 commits into from
Jul 7, 2019

Conversation

hiroshi-matsuda-rit
Copy link
Contributor

No description provided.

izziiyt
izziiyt reviewed Jul 6, 2019
View reviewed changes
tests/mock_grammar.py Show resolved Hide resolved
sudachipy/command_line.py Outdated Show resolved Hide resolved
@izziiyt
Copy link
Collaborator

izziiyt commented Jul 6, 2019

I checked command line and properly change dictionary easily.
Thank you for adding a big new feature !!

@hiroshi-matsuda-rit
Copy link
Contributor Author

hiroshi-matsuda-rit commented Jul 6, 2019 •
edited
Loading

I'm very happy to be able to use user dictionary and install SudachiPy very easily from PyPI!
I'd like to use this version for both spaCy and GiNZA.
Thanks a lot!

izziiyt
izziiyt reviewed Jul 7, 2019
View reviewed changes
README.md Show resolved Hide resolved
@izziiyt
Copy link
Collaborator

izziiyt commented Jul 7, 2019

@hiroshi-matsuda-rit Can I merge your MR ? Are you modifying anything now ?

@hiroshi-matsuda
Copy link
Collaborator

I've finished for this PR. Could you please merge this branch? @izziiyt

@izziiyt izziiyt merged commit 27825cf into WorksApplications:develop Jul 7, 2019
@izziiyt izziiyt mentioned this pull request Jul 7, 2019
Closed
@hiroshi-matsuda-rit hiroshi-matsuda-rit deleted the feature/default_dict_package branch July 7, 2019 05:43
@izziiyt
Copy link
Collaborator

izziiyt commented Jul 7, 2019

@hiroshi-matsuda

Releasing to PyPI will be tomorrow... Because I don't know account info worksapplications on PyPI.
Sorry for inconvenience.

@kazuma-t
Could you release v0.3.0 on PyPI ? Thanks.

@izziiyt
Copy link
Collaborator

izziiyt commented Jul 7, 2019

see #49

@hiroshi-matsuda-rit
Copy link
Contributor Author

I'd try to resolve #49 error but it seems that we should separate dict installation from module package.

@izziiyt
Copy link
Collaborator

izziiyt commented Jul 7, 2019

It looks that, in PyPI platform, all packages in PyPI must be depends on packages in PyPI for security reason. So, I think the easiest solution is giving up default dictionary.

@hiroshi-matsuda-rit
Copy link
Contributor Author

Unfortunately, we should give up to include default dict package installation.
pypa/pip#6301

@hiroshi-matsuda-rit
Copy link
Contributor Author

I'll open a new PR to do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@izziiyt izziiyt izziiyt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiroshi-matsuda-rit @izziiyt @hiroshi-matsuda