Treat NULL values in mapped tables as undefined #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Played with this change a bit and there are quite a lot of corner cases that needs to be properly addressed (mainly in relation to phantom changes). For example right now there is no easy way to unset a property during synchronization process from within the mapping file. Also we probably need to make sure there is a way how to make the JDBC repo behave in a legacy compatible way to not break existing deployments. |
|
Just to add what was the LEGACY behavior even before the recent JDBC repo refactor... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way how
NULLvalues in mapped table columns are handled - allNULLvalues are being treated asundefinedJSON values.This change makes sense as it aligns generic table behavior with the explicitly mapped behavior. However this also makes it impossible to actually save
nullvalues, but supportingundefinedis definitely a more reasonable default. This needs to be properly tested before merging (i.e. no phantom changes when working with Admin UI and during synchronization).