You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements support for modifiers such as Clamp.
See ClampingValidator test for usage examples.
If we decide to go this path we probably will want to rename Validator and validate to something that implies possible modification to the original json value.
Most of the validators can continue receiving a const& of the json value. Only modifiers and containers for other validators/modifiers need to remove the const.
I'm certainly not a huge fan of this "design" but i don't see another way to achieve clamping if we need it.
Sometime in the future perhaps we could integrate the parsing steps into this framework instead of relying on user-provided value_from and value_to but for now this approach is least blood for modifiers support.
Thanks for quickly fixing this!
The mutation in validation looks okay for me. You change the name to "Clamp" which is clear enough. For some validation like account , the validation and parsing is the same operation, currently we do it on accounts twice. In future, with proper parsing step, we can even convert to the different type.
❗ Current head 3a6b9e0 differs from pull request most recent head d78d65a. Consider uploading reports for the commit d78d65a to get more accurate results
Make only modifiers require mutability
[fold] Get const back in tests
[fold] Make tests compile
[fold] Fix const requirement
[fold] Refactor a bit
[fold] A couple more small renames
Handlers and other parts of clio can remain using const object as request now that the default processor makes a copy of the request and validation framework operates on the mutable copy instead.
Modifiers, validators and meta handlers were all refactored out to separate namespaces and files.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
godexsoft
force-pushed
the
feature/rpc-parsing-thru-spec
branch
from
This implements support for modifiers such as
Clamp.See
ClampingValidatortest for usage examples.If we decide to go this path we probably will want to rename
Validatorandvalidateto something that implies possible modification to the original json value.Most of the validators can continue receiving a
const&of the json value. Only modifiers and containers for other validators/modifiers need to remove the const.I'm certainly not a huge fan of this "design" but i don't see another way to achieve clamping if we need it.
Sometime in the future perhaps we could integrate the parsing steps into this framework instead of relying on user-provided
value_fromandvalue_tobut for now this approach is least blood for modifiers support.Let me know your thoughts @cindyyan317 and @ximinez.