-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max_transactions (i.e. mempool) should be a config option rather than hardcoded #3556
Comments
It probably should be. I think it'd be fine to have "hard" limits in the code, and allow server operators to adjust "soft" limits within hard limits. For example:
|
I would like to work on this issue if no one else is actively working on it. |
@ghorbanian go ahead! Thanks for volunteering! |
Cool! Easy fix ... should be easy to get a PR accepted. Clamp on new config value as nik suggested. |
I believe this has already been handled by @natenichols in #3562. |
https:/ripple/rippled/blob/7b048b423e8ae08a54018a89231d050b9f562855/src/ripple/overlay/impl/PeerImp.cpp#L1510-L1514
Not sure why this isn't a config option already?
The text was updated successfully, but these errors were encountered: