-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify fee settings & related calculations #3932
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The fee code is unnecessarily complex, involving arcane concepts like "fee units" and "reference transactions", some of which are adjustable and some of which are not. These values are represented as integers of various widths and a lot of effort is expended to keep all that straight and to help developers avoid doing the wrong thing.
Since the fee units are hard-coded to 10 and the "reference transaction" fee is also 10 and dividing the two gives the identity, there's an opportunity to simply, quickly and easily remove all that complexity, eliminate the whole concept of "fee units" and move to something sane:
XRPAmount
for all fees.All scaling/adjusting of fees would operate directly on
XRPAmount
objects (which are scalars) instead.The text was updated successfully, but these errors were encountered: