Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[account_tx with ledger_index_max, ledger_index_min and ledger_index do not return error] (Version: [1.11.0-rc2]) #4545

Closed
mounikakun opened this issue May 26, 2023 · 1 comment
Closed

[account_tx with ledger_index_max, ledger_index_min and ledger_index do not return error] (Version: [1.11.0-rc2]) #4545

mounikakun opened this issue May 26, 2023 · 1 comment

Comments

@mounikakun
Copy link
Collaborator

Issue Description

Steps to Reproduce

{ "method": "account_tx", "params": [ { "account": "rH9pnDCtgAbFjozbZQuJWvPM8QHweXgZhj", "ledger_index_max": 28953065, "ledger_index_min": 23333389, "ledger_index": 28953075 } ] }

Expected Result

invalidParams

Actual Result

No error

Environment

Supporting Files
@mounikakun
Copy link
Collaborator Author

Issue exists for ledger_index_max, ledger_index_min and ledger_hash also.

@PeterChen13579 PeterChen13579 mentioned this issue Jun 13, 2023
Merged
2 tasks
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Jul 10, 2023
@PeterChen13579 @ckeshava
APIv2: add error messages for account_tx (XRPLF#4571)
c9f7312 
Certain inputs for the AccountTx method should return an error. In other
words, an invalid request from a user or client now results in an error
message.

Since this can change the response from the API, it is an API breaking
change. This commit maintains backward compatibility by keeping the
existing behavior for existing requests. When clients specify
"api_version": 2, they will be able to get the updated error messages.

Update unit tests to check the error based on the API version.

* Fix XRPLF#4288
* Fix XRPLF#4545
@PeterChen13579 PeterChen13579 mentioned this issue Jul 27, 2023
Closed
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 22, 2023
@PeterChen13579 @ckeshava
APIv2: add error messages for account_tx (XRPLF#4571)
179ab0a 
Certain inputs for the AccountTx method should return an error. In other
words, an invalid request from a user or client now results in an error
message.

Since this can change the response from the API, it is an API breaking
change. This commit maintains backward compatibility by keeping the
existing behavior for existing requests. When clients specify
"api_version": 2, they will be able to get the updated error messages.

Update unit tests to check the error based on the API version.

* Fix XRPLF#4288
* Fix XRPLF#4545
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 25, 2023
@PeterChen13579 @ckeshava
APIv2: add error messages for account_tx (XRPLF#4571)
5bad308 
Certain inputs for the AccountTx method should return an error. In other
words, an invalid request from a user or client now results in an error
message.

Since this can change the response from the API, it is an API breaking
change. This commit maintains backward compatibility by keeping the
existing behavior for existing requests. When clients specify
"api_version": 2, they will be able to get the updated error messages.

Update unit tests to check the error based on the API version.

* Fix XRPLF#4288
* Fix XRPLF#4545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mounikakun