Amendments not enabled on networks with network_id greater than 1024 (Version: 2.0.0-b1)

[sgramkumar]

Issue Description

Enabling amendments on network with network_id upto 1024 works fine, but on network with id greater than 1024, amendments are not enabled. Probably this is because the transaction doing the voting is not including the NetworkID which is required if network_id > 1024 and so those transactions are not closed.

On networks with network_id <= 1024

• network_id: 258 => 2:00pm-2:56pm - amendments enabled
• network_id: 1020 => 3:04pm-4:50pm - amendments enabled

On networks with network_id > 1024

• network_id: 1030 => 3:04pm-4:50pm - amendments not enabled
• network_id: 1234 => waited more than 12 hrs wait - amendments not enabled

Steps to Reproduce

1. Update rippled.cfg with network_id to a value greater than 1024

[network_id]
1030

2. Set amendment_majority_time to 30 mins to accelerate amendment voting

[amendment_majority_time]
30 minutes

3. Make sure to remove [features] stanza
4. Bring up a private network (2 validators are enough to reproduce this issue)
5. Once the network is up, vote to enable an amendment (for example: Checks)
   /opt/ripple/bin/rippled --conf /opt/ripple/etc/rippled.cfg feature Checks accept
6. Wait for 30-45 mins (for the next flag ledger to cross)
7. Verify with command: rippled feature | grep -A5 -B3 Checks

Expected Result

Amendment should be enabled for Checks with this response

         "157D2D480E006395B76F948E3E07A45A05FE10230D88A7993C71F97AE4B1F2D1" : {
            "enabled" : true,
            "name" : "Checks",
            "supported" : true
         },

Actual Result

But on network with network_id > 1024, amendment is not enabled after 45 mins too

Command: rippled feature | grep -A5 -B3 Checks

         "157D2D480E006395B76F948E3E07A45A05FE10230D88A7993C71F97AE4B1F2D1" : {
            "count" : 5,
            "enabled" : false,
            "name" : "Checks",
            "supported" : true,
            "threshold" : 3,
            "validations" : 5,
            "vetoed" : false
         },

Environment

Any local network with network_id > 1024

Supporting Files

[intelliot]

• Context on NetworkID