Proposed 0.90.0-b6 #2370
Merged
Proposed 0.90.0-b6 #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes augment the Validations class with a LedgerTrie to better track the history of support for validated ledgers. This improves the selection of the preferred working ledger for consensus. The Validations class now tracks both full and partial validations. Partial validations are only used to determine the working ledger; full validations are required for any quorum related function. Validators are also now explicitly restricted to sending validations with increasing ledger sequence number.
Codecov Report
@@ Coverage Diff @@
## develop #2370 +/- ##
===========================================
+ Coverage 70.08% 70.16% +0.07%
===========================================
Files 702 703 +1
Lines 53346 53157 -189
===========================================
- Hits 37390 37296 -94
+ Misses 15956 15861 -95
Continue to review full report at Codecov.
|
Jenkins Build SummaryBuilt from this commit Built at 20180203 - 13:03:37 Test Results
|
Fixes XRPLF#2350 issue on GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #2300, #2356 , #2357, #2362.