-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed 1.6.0-b5 #3388
Merged
Merged
Proposed 1.6.0-b5 #3388
Commits on May 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 567e42e - Browse repository at this point
Copy the full SHA 567e42eView commit details -
This commit introduces the "HardenedValidations" amendment which, if enabled, allows validators to include additional information in their validations that can increase the robustness of consensus. Specifically, the commit introduces a new optional field that can be set in validation messages can be used to attest to the hash of the latest ledger that a validator considers to be fully validated. Additionally, the commit leverages the previously introduced "cookie" field to improve the robustness of the network by making it possible for servers to automatically detect accidental misconfiguration which results in two or more validators using the same validation key.
Configuration menu - View commit details
-
Copy full SHA for 381606a - Browse repository at this point
Copy the full SHA 381606aView commit details -
Report the server version in published validations:
Currently there is no mechanism for a validator to report the version of the software it is currently running. Such reports can be useful for those who are developing network monitoring dashboards and server operators in general. This commit, if merged, defines an encoding scheme to encode a version string into a 64-bit unsigned integer and adds an additional optional field to validations. This commit piggybacks on "HardenedValidations" amendment to determine whether version information should be propagated or not. The general encoding scheme is: XXXXXXXX-XXXXXXXX-YYYYYYYY-YYYYYYYY-YYYYYYYY-YYYYYYYY-YYYYYYYY-YYYYYYYY X: 16 bits identifying the particular implementation Y: 48 bits of data specific to the implementation The rippled-specific format (implementation ID is: 0x18 0x3B) is: 00011000-00111011-MMMMMMMM-mmmmmmmm-pppppppp-TTNNNNNN-00000000-00000000 M: 8-bit major version (0-255) m: 8-bit minor version (0-255) p: 8-bit patch version (0-255) T: 11 if neither an RC nor a beta 10 if an RC 01 if a beta N: 6-bit rc/beta number (1-63)
Configuration menu - View commit details
-
Copy full SHA for 2827de4 - Browse repository at this point
Copy the full SHA 2827de4View commit details -
Improve loading of validator tokens (RIPD-1687):
A deliberately malformed token can cause the server to crash during startup. This is not remotely exploitable and would require someone with access to the configuration file of the server to make changes and then restart the server. Acknowledgements: Guido Vranken for responsibly disclosing this issue. Bug Bounties and Responsible Disclosures: We welcome reviews of the rippled code and urge researchers to responsibly disclose any issues they may find. Ripple is generously sponsoring a bug bounty program for the rippled project. For more information please visit: https://ripple.com/bug-bounty
Configuration menu - View commit details
-
Copy full SHA for 6c72d5c - Browse repository at this point
Copy the full SHA 6c72d5cView commit details
Commits on May 5, 2020
-
This commit removes obsolete comments, dead or no longer useful code, and workarounds for several issues that were present in older compilers that we no longer support. Specifically: - It improves the transaction metadata handling class, simplifying its use and making it less error-prone. - It reduces the footprint of the Serializer class by consolidating code and leveraging templates. - It cleanups the ST* class hierarchy, removing dead code, improving and consolidating code to reduce complexity and code duplication. - It shores up the handling of currency codes and the conversation between 160-bit currency codes and their string representation. - It migrates beast::secure_erase to the ripple namespace and uses a call to OpenSSL_cleanse instead of the custom implementation.
Configuration menu - View commit details
-
Copy full SHA for dbee3f0 - Browse repository at this point
Copy the full SHA dbee3f0View commit details -
Prefer keylets instead of naked hashes:
Entries in the ledger are located using 256-bit locators. The locators are calculated using a wide range of parameters specific to the entry whose locator we are calculating (e.g. an account's locator is derived from the account's address, whereas the locator for an offer is derived from the account and the offer sequence.) Keylets enhance type safety during lookup and make the code more robust, so this commit removes most of the earlier code, which used naked uint256 values.
Configuration menu - View commit details
-
Copy full SHA for 74f9ede - Browse repository at this point
Copy the full SHA 74f9edeView commit details -
Remove the built-in "sustain" watchdog:
The built-in watchdog is simplistic and can, sometimes, cause problems especially on systems that have the ability to automatically start and monitor processes. This commit removes the sustain system entirely, changes the handling of the SIGTERM signal to properly terminate the process and improves the error message reported to the user when the command line used to start `rippled` is incorrect and malformed.
Configuration menu - View commit details
-
Copy full SHA for 62a3f33 - Browse repository at this point
Copy the full SHA 62a3f33View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbd25f0 - Browse repository at this point
Copy the full SHA dbd25f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a00543b - Browse repository at this point
Copy the full SHA a00543bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57b3543 - Browse repository at this point
Copy the full SHA 57b3543View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fad421 - Browse repository at this point
Copy the full SHA 4fad421View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11be30d - Browse repository at this point
Copy the full SHA 11be30dView commit details -
Add descriptive comments to 'getRippledInfo.sh':
The script, when invoked by a server operator can collect information useful for debugging, while attempting to redact potentially sensitive data. It contained no explanation or other exposition to allow people who look at the file but aren't familiar with shell scripts to understand its purpose.
Configuration menu - View commit details
-
Copy full SHA for d025f3f - Browse repository at this point
Copy the full SHA d025f3fView commit details -
Cleanup the 'PeerSet' hierarchy:
This commit introduces no functional changes but cleans up the code and shrinks the surface area by removing dead and unused code, leveraging std:: alternatives to hand-rolled code and improving comments and documentation.
Configuration menu - View commit details
-
Copy full SHA for 5b5226d - Browse repository at this point
Copy the full SHA 5b5226dView commit details -
Extend unit testing of account_tx with deleted account:
The unit test now verifies that if an account is not present in the starting account_tx ledger, account_tx still iterates down and finds the transaction that deletes the account (and earlier transactions).
Configuration menu - View commit details
-
Copy full SHA for 894d346 - Browse repository at this point
Copy the full SHA 894d346View commit details -
Configuration menu - View commit details
-
Copy full SHA for d88a7c7 - Browse repository at this point
Copy the full SHA d88a7c7View commit details -
Revert "Add PR automation for project boards"
This reverts commit cd78ce3.
Configuration menu - View commit details
-
Copy full SHA for d9fa148 - Browse repository at this point
Copy the full SHA d9fa148View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9771210 - Browse repository at this point
Copy the full SHA 9771210View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.