Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find date::date in CMake package configuration file #3399

Closed
wants to merge 1 commit into from

Conversation

thejohnfreeman
Copy link
Collaborator

Came across this problem while trying to build validator-keys-tool.

@manojsdoshi
Copy link
Contributor

@thejohnfreeman the CI job is failing for your changes

@thejohnfreeman
Copy link
Collaborator Author

It's failing for everyone on MacOS because c-ares 1.16.1 added a link dependency on libresolv that our CMake configuration is not picking up.

Copy link
Contributor

@carlhua carlhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thejohnfreeman thejohnfreeman added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label May 18, 2020
This was referenced May 21, 2020
@thejohnfreeman thejohnfreeman deleted the find-dep-date branch October 28, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants