Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix usage of pkg-config for static linking #3406

Closed
wants to merge 1 commit into from

Conversation

thejohnfreeman
Copy link
Collaborator

Let's see if this works... I have to open a PR to test the CI without creating a branch.

@codecov-io
Copy link

Codecov Report

Merging #3406 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3406   +/-   ##
========================================
  Coverage    70.44%   70.44%           
========================================
  Files          682      682           
  Lines        54392    54392           
========================================
  Hits         38315    38315           
  Misses       16077    16077           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9771210...5126020. Read the comment docs.

@thejohnfreeman thejohnfreeman added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label May 18, 2020
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants