Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve online_delete configuration and DB tuning: #3429

Closed
wants to merge 13 commits into from

Commits on Jun 2, 2020

  1. Make server_info report consistent with internal

    evaluations for validated ledger age.
    mtrippled authored and ximinez committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    063c3b8 View commit details
    Browse the repository at this point in the history
  2. Improve online_delete configuration and DB tuning:

    * Document delete_batch, back_off_milliseconds, age_threshold_seconds.
    * Convert those time values to chrono types.
    * Fix bug that ignored age_threshold_seconds.
    * Add a "recovery buffer" to the config that gives the node a chance to
      recover before aborting online delete.
    * Add begin/end log messages around the SQL queries.
    * Add a new configuration section: [sqlite] to allow tuning the sqlite
      database operations. Ignored on full/large history servers.
    * Update documentation of [node_db] and [sqlite] in the
      rippled-example.cfg file.
    * Resolves XRPLF#3321
    ximinez committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    6e9051e View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Configuration menu
    Copy the full SHA
    4b40877 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e42c1ee View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Configuration menu
    Copy the full SHA
    f10c335 View commit details
    Browse the repository at this point in the history
  2. [FOLD] Review feedback from @nbougalis:

    (Include these items in the main commit when squashing.)
    * Update rippled URLs in documentation.
    * Full history and fetch depth use max() value instead of an arbitrary
      value of 1 billion.
    ximinez committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    088d0af View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. [fold] review feeback from @nbougalis 2:

    * changed the sqlite ledger_history cutoff to log a warning instead of
      ignoring sqlite settings. updated documentation.
    * integrated the commonpragma back in to the setup struct and restored
      the interface of the databasecon ctors.
    ximinez committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    6b96876 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. [fold] add unit tests for log messages added last commit

    * involved moving some test logging subclasses around to be more easily
      accessible, and some minor refactoring of Env.
    ximinez committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    18f5d07 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. [FOLD] Review feedback from @mtravis, part 1:

    * Make `safety_level` and other tuning options mutually exclusive
    * Clean up VACUUM functionality and tuning to use settings.
    * Fix bugs in the config setup where it still ignored tuning settings if
      full history. Add tests to catch that mistake.
    * Fix some bugs in the unit tests, and make them more robustly check
      error messages.
    ximinez committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    9173a6a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. [FOLD] Review feedback from @mtravis, part 2:

    * Change some log message levels.
    * clearSql no longer returns a bool that every caller ignores.
    * Restructure a few unnecessary validity checks
    ximinez committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    10e02e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e060249 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. [FOLD] Review feedback from @seelabs and @mtrippled:

    * Rename retry_buffer_seconds to retry_wait_seconds.
    * Improve documentation and examples in example.cfg file.
    * Simplify the DatabaseCon::Setup pragma handling.
    * Other misc cleanups
    ximinez committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    c1fff2e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. [FOLD] Review feedback from @mDuo13 and @seelabs:

    * Improved some of the documentation and log messages
    * Removed the unnecessary `DatabaseCon::Base` ctor helper class
    ximinez committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    2b01158 View commit details
    Browse the repository at this point in the history