-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose 1.9.1-b1 #4158
Closed
Closed
Propose 1.9.1-b1 #4158
Commits on May 6, 2022
-
Adjust thread count calculation and request bundling:
This commit addresses minor bugs introduced with commit 6faaa91: - The number of threads used by the database engine was incorrectly clamped to the lower possible value, such that the database was effectively operating in single threaded mode. - The number of requests to extract at once was so high that it could result in increased latency. The bundle size is now limited to 4 and can be adjusted by a new configuration option `rq_bundle` in the `[node_db]` stanza. This is an advanced tunable and adjusting it should not be needed.
Configuration menu - View commit details
-
Copy full SHA for 245174c - Browse repository at this point
Copy the full SHA 245174cView commit details -
Adjust the aggressiveness of the ledger acquisition engine:
Several hard-coded parameters control the behavior of the ledger acquisition engine. The values of many of these parameters where set by intuition and have complex and non-intuitive interactions with each other and other parts of the code. An earlier commit attempted to adjust several of these parameters to improve syncing performance; initial testing was promising but a number of operators reported experiencing syncing and stability issues with their servers. As a result, this commit reverts parts of commit 1823506. This commit further adjusts some tunables so as to increase the aggressiveness of the ledger acquisition engine.
Configuration menu - View commit details
-
Copy full SHA for b68a669 - Browse repository at this point
Copy the full SHA b68a669View commit details
Commits on May 10, 2022
-
Ensure that
rngfill
returns the requested amount of randomness:One of the two versions of the `rngfill` function accepts a pointer to a buffer and a size (in bytes). The function aims to fill the provided `buffer` with `size` random bytes. It does this in chunks of 8 bytes, for long as possible, and then fills any left-over gap one byte at a time. To avoid an annoying and incorrect warning about a potential buffer overflow in the "trailing write", commit 78bc272 used a `#pragma` to instruct the compiler to not generate the incorrect diagnostic. Unfortunately, this change _also_ eliminated the trailing write code, which means that, under some cases, the `rngfill` function would generate between 1 and 7 fewer random bytes than requested. This problem would only manifest on builds that do not define `__GNUC__` which, as of this writing, means MSVC.
Configuration menu - View commit details
-
Copy full SHA for 7ca1f78 - Browse repository at this point
Copy the full SHA 7ca1f78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87d06a2 - Browse repository at this point
Copy the full SHA 87d06a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfe69f1 - Browse repository at this point
Copy the full SHA dfe69f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aedb0e - Browse repository at this point
Copy the full SHA 5aedb0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa4a5b7 - Browse repository at this point
Copy the full SHA aa4a5b7View commit details -
Don't load trust lines that can't participate in path finding
* "A path is considered invalid if and only if it enters and exits an address node through trust lines where No Ripple has been enabled for that address." (https://xrpl.org/rippling.html#specifics) * When loading trust lines for an account "Alice" which was reached via a trust line that has the No Ripple flag set on Alice's side, do not use or cache any of Alice's trust lines which have the No Ripple flag set on Alice's side. For typical "end-user" accounts, this will return no trust lines.
Configuration menu - View commit details
-
Copy full SHA for e836375 - Browse repository at this point
Copy the full SHA e836375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04bd587 - Browse repository at this point
Copy the full SHA 04bd587View commit details -
Introduce the
ExpandedSignerList
amendment:The amendment increases the maximum sign of an account's signer list from 8 to 32. Like all new features, the associated amendment is configured with a default vote of "no" and server operators will have to vote for it explicitly if they believe it is useful.
1Configuration menu - View commit details
-
Copy full SHA for 01c37fe - Browse repository at this point
Copy the full SHA 01c37feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 767dd4f - Browse repository at this point
Copy the full SHA 767dd4fView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for dac080f - Browse repository at this point
Copy the full SHA dac080fView commit details -
Introduce fixNFTokenDirV1 amendment:
o Fixes an off-by-one when determining which NFTokenPage an NFToken belongs on. o Improves handling of packed sets of 32 NFTs with identical low 96-bits. o Fixes marker handling by the account_nfts RPC command. o Tightens constraints of NFTokenPage invariant checks. Adds unit tests to exercise the fixed cases as well as tests for previously untested functionality.
Configuration menu - View commit details
-
Copy full SHA for 80bda7c - Browse repository at this point
Copy the full SHA 80bda7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 670bc22 - Browse repository at this point
Copy the full SHA 670bc22View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.