Catch missing node error when rotating database #4182
Conversation
| catch (SHAMapMissingNode const& e) | ||
| { | ||
| JLOG(journal_.error()) | ||
| << "Missing node while copying ledger before roate: " |
| @@ -30,6 +30,7 @@ | |||
| #include <ripple/nodestore/Scheduler.h> | |||
|
|
|||
| #include <boost/algorithm/string/predicate.hpp> | |||
| #include "ripple/shamap/SHAMapMissingNode.h" | |||
There was a problem hiding this comment.
Could you use chevrons to enclose this #include? And move it up with the ripple includes please? Thanks.
There was a problem hiding this comment.
@scottschurr Fixed - also an explanation: I changed my editor configuration and it started "helpfully" adding include files for me. I need to figure out how to turn that off. I missed that is added that for me. Thanks for spotting it!
There was a problem hiding this comment.
@haihai423: Short answer: no. Longer answer: Still no. I believe that Radar Coin simply cloned this code (along with several libraries and even entire websites), only changing the name.
There was a problem hiding this comment.
Changes look good to me once the new #include is fixed up. Thanks.
I'm going to let this code burn in for a while on the same machine that saw the crash yesterday. There's no guarantee that I'll see the same problem, but I may as well give it a try. If I don't see any crashes after it burns in for a few hours I'll give it the thumbs up.
There was a problem hiding this comment.
I did a burn in with this code over the weekend. Unfortunately, and to no one's surprise, the burning in code neither crashed nor left a message in the log to verify that we really fixed things up with this change. But I think there's a high likelihood that this is the right change.
Let's do this. Thanks for the fix. 👍
While there should never be a missing node when copying the SHAMap, rippled should not terminate when there's an error rotating the database. This patch aborts the database rotation rather than aborting rippled.
|
Squashed and marked passed |
seelabs
added
the
Passed
While there should never be a missing node when copying the SHAMap,
rippled should not terminate when there's an error rotating the
database. This patch aborts the database rotation rather than aborting rippled.