Work around gdb bug by changing a template parameter: #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
requested changes
Nov 3, 2022
scottschurr
reviewed
Nov 3, 2022
|
👍 LGTM. Happy pretty printing. |
scottschurr
approved these changes
Nov 3, 2022
seelabs
added
the
Passed
|
Thanks both for the quick review. Squashed and put a "passed" label on this. |
ximinez
requested changes
Nov 23, 2022
ximinez
removed
the
Passed
There's a bug in gdb where unsigned template parameters cause issues with RTTI. This patch changes a template parameter from `size_t` to `int` to workaround this gdb bug.
|
Fixed commit message. (@ximinez ) |
seelabs
added
the
Passed
ximinez
approved these changes
Nov 29, 2022
intelliot
changed the title
dangell7
pushed a commit
to Transia-RnD/rippled
that referenced
this pull request
Mar 5, 2023
There's a bug in gdb where unsigned template parameters cause issues with RTTI. This patch changes a template parameter from `size_t` to `int` to work around this gdb bug.
tequdev
pushed a commit
to tequdev/rippled
that referenced
this pull request
Nov 17, 2023
There's a bug in gdb where unsigned template parameters cause issues with RTTI. This patch changes a template parameter from `size_t` to `int` to work around this gdb bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in gdb where unsigned template parameters cause issues with RTTI. This patch changes a template parameter from
size_ttointto workaround this gdb bug.