Update documented pathfinding configuration defaults: #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add recommended values for node which want to support "advanced" pathfinding, which is effectively the old default behavior.
intelliot
approved these changes
Feb 6, 2023
* upstream/develop: Revise CONTRIBUTING (XRPLF#4382)
ledhed2222
reviewed
Feb 6, 2023
| @@ -758,7 +758,9 @@ | |||
| # When searching for paths, the default search aggressiveness. This can take | |||
| # exponentially more resources as the size is increased. | |||
| # | |||
| # The default is: 7 | |||
| # The recommended value to support advanced pathfinding is: 7 | |||
There was a problem hiding this comment.
Yep. That's pretty much it. I kind of intentionally left it vague because anybody who doesn't specifically want pathfinding will be just fine with the defaults, and anyone who does probably just wants a reasonable recommendation. If they are more advanced than that, then any "tl;dr" summary in the config file is going to be insufficient - those users should dig into the code or other documentation.
ledhed2222
reviewed
Feb 6, 2023
| @@ -767,12 +769,19 @@ | |||
| # If you do not need pathfinding, you can set path_search_max to zero to | |||
| # disable it and avoid some expensive bookkeeping. | |||
| # | |||
| # The default for 'path_search_fast' is 2. The default for 'path_search_max' is 10. | |||
| # To support advanced pathfinding the recommended value for | |||
| # 'path_search_fast' is 2, and for 'path_search_max' is 10. | |||
ledhed2222
reviewed
Feb 6, 2023
| # aggressiveness to use. The default is 7. | ||
| # aggressiveness to use. | ||
| # | ||
| # The recommended value to support advanced pathfinding is: 7. |
ledhed2222
approved these changes
Feb 6, 2023
intelliot
added
Trivial
Passed
* upstream/develop: Update dependency: grpc (XRPLF#4407) Introduce min/max observers for Number Optimize uint128_t division by 10 within Number.cpp Replace Number division algorithm Include rounding mode in XRPAmount to STAmount conversion. Remove undefined behavior * Taking the negative of a signed negative is UB, but taking the negative of an unsigned is not. Silence warnings Introduce rounding modes for Number: Use Number for IOUAmount and STAmount arithmetic Add tests Add implicit conversion from STAmount to Number Add clip Add conversions between Number, XRPAmount and int64_t AMM Add Number class and associated algorithms
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 9, 2023
* upstream/develop: Update documented pathfinding configuration defaults: (XRPLF#4409)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 9, 2023
* upstream/develop: Update documented pathfinding configuration defaults: (XRPLF#4409)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 9, 2023
* upstream/develop: Update documented pathfinding configuration defaults: (XRPLF#4409)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 9, 2023
* upstream/develop: Update documented pathfinding configuration defaults: (XRPLF#4409)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 9, 2023
* upstream/develop: Update documented pathfinding configuration defaults: (XRPLF#4409)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 9, 2023
…ctionality * upstream/develop: Update documented pathfinding configuration defaults: (XRPLF#4409) Update dependency: grpc (XRPLF#4407) Introduce min/max observers for Number Optimize uint128_t division by 10 within Number.cpp Replace Number division algorithm Include rounding mode in XRPAmount to STAmount conversion. Remove undefined behavior * Taking the negative of a signed negative is UB, but taking the negative of an unsigned is not. Silence warnings Introduce rounding modes for Number: Use Number for IOUAmount and STAmount arithmetic Add tests Add implicit conversion from STAmount to Number Add clip Add conversions between Number, XRPAmount and int64_t AMM Add Number class and associated algorithms Revise CONTRIBUTING (XRPLF#4382)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Feb 9, 2023
…tpage * upstream/develop: (37 commits) Update documented pathfinding configuration defaults: (XRPLF#4409) Update dependency: grpc (XRPLF#4407) Introduce min/max observers for Number Optimize uint128_t division by 10 within Number.cpp Replace Number division algorithm Include rounding mode in XRPAmount to STAmount conversion. Remove undefined behavior * Taking the negative of a signed negative is UB, but taking the negative of an unsigned is not. Silence warnings Introduce rounding modes for Number: Use Number for IOUAmount and STAmount arithmetic Add tests Add implicit conversion from STAmount to Number Add clip Add conversions between Number, XRPAmount and int64_t AMM Add Number class and associated algorithms Revise CONTRIBUTING (XRPLF#4382) `XRPFees`: Fee setting and handling improvements (XRPLF#4247) Update BUILD.md (XRPLF#4383) Make NodeToShardRPC a manual test (XRPLF#4379) Update build instructions (XRPLF#4376) ...
dangell7
pushed a commit
to Transia-RnD/rippled
that referenced
this pull request
Mar 5, 2023
* Add recommended values for node which want to support "advanced" pathfinding, which is effectively the old default behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
417cfc2 changed the default Path Finding configuration values, but missed updating the values documented in rippled-example.cfg.
This change updates those defaults, and adds recommended values for node which want to support "advanced" pathfinding, which is effectively the old default behavior.
Type of Change