Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename fixUnburnableNFToken to fixNonFungibleTokensV1_2 and some cosmetic changes #4419

Merged
merged 1 commit into from
Feb 13, 2023
Merged

rename fixUnburnableNFToken to fixNonFungibleTokensV1_2 and some cosmetic changes #4419

merged 1 commit into from
Feb 13, 2023

Conversation

ledhed2222
Copy link
Contributor

@ledhed2222 ledhed2222 commented Feb 13, 2023 •
edited
Loading

High Level Overview of Change

title says it all

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@ledhed2222 ledhed2222 requested review from shawnxie999 and scottschurr and removed request for shawnxie999 February 13, 2023 18:39
@kennyzlei
Copy link
Collaborator

@ledhed2222 nit: can you update the PR description to be closer to #4416 ? "rename amendment" does not make it clear which amendment you are renaming

@ledhed2222 ledhed2222 changed the title rename amendment and some cosmetic changes rename fixUnburnableNFToken to fixNonFungibleTokensV1_2 and some cosmetic changes Feb 13, 2023
@kennyzlei kennyzlei mentioned this pull request Feb 13, 2023
Closed
7 tasks
kennyzlei
kennyzlei approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@kennyzlei kennyzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

do you want to address this comment change #4417 (comment) here? we also can save it for a later time due to rebuild/test times

@kennyzlei kennyzlei mentioned this pull request Feb 13, 2023
Merged
7 tasks
@ledhed2222 ledhed2222 added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Feb 13, 2023
scottschurr
scottschurr approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manojsdoshi manojsdoshi merged commit ab9aaec into XRPLF:feature/nft-fixes Feb 13, 2023
kennyzlei pushed a commit that referenced this pull request Feb 13, 2023
@ledhed2222 @kennyzlei
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (#4419)
05602af
kennyzlei pushed a commit that referenced this pull request Feb 13, 2023
@ledhed2222 @kennyzlei
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (#4419)
48ec19d 
Signed-off-by: Kenny Lei <[email protected]>
kennyzlei pushed a commit that referenced this pull request Feb 13, 2023
@ledhed2222 @kennyzlei
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (#4419)
2ec7471
kennyzlei pushed a commit that referenced this pull request Feb 13, 2023
@ledhed2222 @kennyzlei
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (#4419)
ac78b7a
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
269800f 
)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into github-ci
6f4e383 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into neverfeature
a102cd0 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
34a72b8 
)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into ledgerinit
5144073 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into badmarker
6d7628b 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
956e600 
)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into action-annoyances
a7c0249 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into site-timeout
c3474c5 
* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into gt--amm-core-fun…
7c1557f 
…ctionality

* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
dec8ca1 
)
ximinez added a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ximinez
Merge remote-tracking branch 'upstream/develop' into badmarker_rh--nf…
7341b46 
…tpage

* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
  Change default vote on fixUniversalNumber from yes to no (XRPLF#4414)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
df1fef7 
)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
568ef76 
)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
924c76f 
)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
1c79625 
)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
f79442e 
)
ximinez pushed a commit to ximinez/rippled that referenced this pull request Feb 15, 2023
@ledhed2222 @ximinez
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
41f320e 
)
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Mar 5, 2023
@ledhed2222 @dangell7
Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419
6bded06 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyzlei kennyzlei kennyzlei approved these changes

@scottschurr scottschurr scottschurr approved these changes

@shawnxie999 shawnxie999 shawnxie999 approved these changes

Assignees

@intelliot intelliot

@scottschurr scottschurr

@shawnxie999 shawnxie999

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ledhed2222 @kennyzlei @scottschurr @shawnxie999 @intelliot @manojsdoshi