Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test ripple.app.LedgerData #4484

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

drlongle
Copy link
Contributor

High Level Overview of Change

PR #4398 was recently merged without a rebase on develop branch's latest commit. This causes the unit test ripple.app.LedgerData to break because it was assumed that there was no fee data by default. This is no longer true because of PR #4319. This PR fixes the failed unit test ripple.app.LedgerData.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@intelliot intelliot merged commit e6f4904 into XRPLF:develop Mar 31, 2023
@drlongle drlongle deleted the fix-ledger-data-unit-test branch April 3, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants