Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(BUILD): make it easier to find environment.md #4507

Merged
merged 7 commits into from
Sep 16, 2023

Conversation

intelliot
Copy link
Collaborator

High Level Overview of Change

Make the instructions a bit easier to follow. Users on different platforms can look for their platform name to find relevant information.

Context of Change

It was a bit difficult to find the helpful instructions in environment.md.

Type of Change

  • Documentation Updates

Make the instructions a bit easier to follow. Users on different platforms can look for their platform name to find relevant information.
Copy link
Collaborator

@ckeshava ckeshava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMK your thoughts. I can work on modifying this document.

BUILD.md Show resolved Hide resolved
BUILD.md Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
@intelliot intelliot requested a review from ckeshava April 21, 2023 23:51
@intelliot
Copy link
Collaborator Author

@ckeshava feel free to propose other changes to this document, as you like.

@ckeshava
Copy link
Collaborator

It looks good to me.

I'm curious: Are there any plans to provide a DockerFile for people to spin up the rippled executable? It might not be suitable for development environment, but it might simplify the user experience for only maintaining a validator on the ledger.

@intelliot
Copy link
Collaborator Author

@ckeshava re: Dockerfile, does this provide what you're looking for? -

also: in GitHub, you can go to "Files changed" -> "Review changes" to submit a review of this PR

Copy link
Collaborator

@ckeshava ckeshava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good to me 👍

@ckeshava
Copy link
Collaborator

@intelliot thanks, yes I was looking for a dockerfile to make it easy to install a rippled instance. I have also submitted the review.

Copy link
Contributor

@ggprod ggprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

BUILD.md Outdated Show resolved Hide resolved
BUILD.md Show resolved Hide resolved
BUILD.md Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
@thejohnfreeman
Copy link
Collaborator

I will try to catch up with this by the end of next week.

@intelliot intelliot requested a review from ckeshava June 28, 2023 17:40
@intelliot
Copy link
Collaborator Author

@ckeshava as this PR has been updated since your last review, could you re-review?

@ckeshava
Copy link
Collaborator

I think the commits need to be rebased to the latest develop branch

@intelliot intelliot changed the title Update BUILD.md - make it easier to find environment.md docs(BUILD): make it easier to find environment.md Jun 28, 2023
@intelliot intelliot added the Documentation README changes, code comments, etc. label Sep 13, 2023
@intelliot intelliot dismissed thejohnfreeman’s stale review September 16, 2023 04:52

requested changes have been resolved

@intelliot intelliot merged commit 3397922 into develop Sep 16, 2023
30 checks passed
@intelliot intelliot deleted the build-environment branch September 16, 2023 04:54
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 22, 2023
Make the instructions a bit easier to follow. Users on different
platforms can look for their platform name to find relevant information.
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 25, 2023
Make the instructions a bit easier to follow. Users on different
platforms can look for their platform name to find relevant information.
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Make the instructions a bit easier to follow. Users on different
platforms can look for their platform name to find relevant information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation README changes, code comments, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants