-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AMM): prevent orphaned objects, inconsistent ledger state: (updates XLS-30) #4626
Closed
Commits on Jul 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da44bc8 - Browse repository at this point
Copy the full SHA da44bc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cead5b - Browse repository at this point
Copy the full SHA 5cead5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for eaef4b6 - Browse repository at this point
Copy the full SHA eaef4b6View commit details
Commits on Jul 18, 2023
-
Allow SetTrust on AMM only for LP tokens and other changes
* Add AMMID to AMM root account * Remove owner dir entry for ltAMM
Configuration menu - View commit details
-
Copy full SHA for b28101f - Browse repository at this point
Copy the full SHA b28101fView commit details
Commits on Jul 23, 2023
-
Add AMMDelete to handle amortized deletion and other changes to addre…
…ss reviewer's feedback * Limit number of trustlines to delete on final withdraw and AMMDelete * Enable AMM in empty state when LPTokens is 0 in final withdraw * Disallow trustlines to AMM in empty state * Add utility functions to delete nodes on AccountDelete and AMM account delete * Add tfTwoAssetIfEmpty deposit option in AMM empty state * Fail all AMM transactions in AMM empty state except special deposit * Add tecINCOMPLETE to indicate not all AMM trustlines are deleted; handle it in Transactor similar to deleted offers * Extend the unit-tests
Configuration menu - View commit details
-
Copy full SHA for cbd7144 - Browse repository at this point
Copy the full SHA cbd7144View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 40317c5 - Browse repository at this point
Copy the full SHA 40317c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cf3fd7 - Browse repository at this point
Copy the full SHA 9cf3fd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75af923 - Browse repository at this point
Copy the full SHA 75af923View commit details
Commits on Jul 28, 2023
-
Maintain AMM trustlines count in AMM root account and other changes a…
…ddressing reviewer's feedback * AMMWithdraw deletes AMM trustlines and AMM account/object only if number of trustlines is less than max * Add tecAMM_NOT_EMPTY to flag cases that expect AMM in empty state * Don't validate for invalid asset pair in AMMDelete * Use Sandbox instead of ApplyView in some utility functions * Other minor refactoring
Configuration menu - View commit details
-
Copy full SHA for cd88481 - Browse repository at this point
Copy the full SHA cd88481View commit details
Commits on Jul 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9ddff74 - Browse repository at this point
Copy the full SHA 9ddff74View commit details
Commits on Jul 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2b1c8c6 - Browse repository at this point
Copy the full SHA 2b1c8c6View commit details
Commits on Aug 1, 2023
-
Disallow AMM create if issuer has clawback enabled and other changes
* Rollback AMM handling in clawback transactor * Use tecINCOMPLETE as indicator of partial deletion in cleanupOnAccountDelete() and deleteAMMTrustLines() * Return tecINTERNAL if AMM root account is nullptr in deleteAMMAccount() * Enable partial trustline deletion in AMMWithdraw * Refactor AccountRootsNotDeleted::finalize() * Refactor SetTrust::preclaim()
Configuration menu - View commit details
-
Copy full SHA for c5e3c89 - Browse repository at this point
Copy the full SHA c5e3c89View commit details
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b63e696 - Browse repository at this point
Copy the full SHA b63e696View commit details
Commits on Aug 4, 2023
-
Rall-back lsfAllowTrustLineClawback flag and other changes
* Add const ammID_ to AMM jtx class * Update changelog * Add testcase name
Configuration menu - View commit details
-
Copy full SHA for 2efa0f8 - Browse repository at this point
Copy the full SHA 2efa0f8View commit details
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fa0d9c4 - Browse repository at this point
Copy the full SHA fa0d9c4View commit details
Commits on Aug 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e2c454 - Browse repository at this point
Copy the full SHA 7e2c454View commit details
Commits on Aug 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c07bb67 - Browse repository at this point
Copy the full SHA c07bb67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 484e01f - Browse repository at this point
Copy the full SHA 484e01fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfa3201 - Browse repository at this point
Copy the full SHA cfa3201View commit details -
Add comments to stress that the selection tests would have to be upda…
…ted if OwnerPaysFeature is enabled.
Configuration menu - View commit details
-
Copy full SHA for a34d29b - Browse repository at this point
Copy the full SHA a34d29bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.