Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AMM): prevent orphaned objects, inconsistent ledger state: (updates XLS-30) #4626

Closed
wants to merge 20 commits into from

Commits on Jul 17, 2023

  1. Configuration menu
    Copy the full SHA
    da44bc8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5cead5b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eaef4b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Allow SetTrust on AMM only for LP tokens and other changes

    * Add AMMID to AMM root account
    * Remove owner dir entry for ltAMM
    gregtatcam committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    b28101f View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. Add AMMDelete to handle amortized deletion and other changes to addre…

    …ss reviewer's feedback
    
    * Limit number of trustlines to delete on final withdraw and AMMDelete
    * Enable AMM in empty state when LPTokens is 0 in final withdraw
    * Disallow trustlines to AMM in empty state
    * Add utility functions to delete nodes on AccountDelete and AMM account delete
    * Add tfTwoAssetIfEmpty deposit option in AMM empty state
    * Fail all AMM transactions in AMM empty state except special deposit
    * Add tecINCOMPLETE to indicate not all AMM trustlines are deleted; handle it in Transactor similar to deleted offers
    * Extend the unit-tests
    gregtatcam committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    cbd7144 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    40317c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cf3fd7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75af923 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Maintain AMM trustlines count in AMM root account and other changes a…

    …ddressing reviewer's feedback
    
    * AMMWithdraw deletes AMM trustlines and AMM account/object only if number of trustlines is less than max
    * Add tecAMM_NOT_EMPTY to flag cases that expect AMM in empty state
    * Don't validate for invalid asset pair in AMMDelete
    * Use Sandbox instead of ApplyView in some utility functions
    * Other minor refactoring
    gregtatcam committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    cd88481 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Configuration menu
    Copy the full SHA
    9ddff74 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    2b1c8c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Disallow AMM create if issuer has clawback enabled and other changes

    * Rollback AMM handling in clawback transactor
    * Use tecINCOMPLETE as indicator of partial deletion in cleanupOnAccountDelete() and deleteAMMTrustLines()
    * Return tecINTERNAL if AMM root account is nullptr in deleteAMMAccount()
    * Enable partial trustline deletion in AMMWithdraw
    * Refactor AccountRootsNotDeleted::finalize()
    * Refactor SetTrust::preclaim()
    gregtatcam committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c5e3c89 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    b63e696 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Rall-back lsfAllowTrustLineClawback flag and other changes

    * Add const ammID_ to AMM jtx class
    * Update changelog
    * Add testcase name
    gregtatcam committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2efa0f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    fa0d9c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Configuration menu
    Copy the full SHA
    7e2c454 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    c07bb67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    484e01f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfa3201 View commit details
    Browse the repository at this point in the history
  4. Add comments to stress that the selection tests would have to be upda…

    …ted if OwnerPaysFeature is enabled.
    gregtatcam committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    a34d29b View commit details
    Browse the repository at this point in the history