Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRIVIAL] Link compression in example cfg #4753

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[TRIVIAL] Link compression in example cfg #4753

merged 1 commit into from
Oct 6, 2023

Conversation

florent-uzio
Copy link
Collaborator

@florent-uzio florent-uzio commented Oct 6, 2023 •
edited by intelliot
Loading

This PR adds the link compression setting to the rippled-example.cfg file in the second section "Peer Protocol".

It solves #4656

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@florent-uzio florent-uzio mentioned this pull request Oct 6, 2023
Closed
7 tasks
gregtatcam
gregtatcam approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

intelliot
intelliot approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: diff is identical to #4739

@intelliot intelliot added the Documentation README changes, code comments, etc. label Oct 6, 2023
@intelliot intelliot changed the title Link compression in example cfg [TRIVIAL] Link compression in example cfg Oct 6, 2023
@intelliot intelliot merged commit ced14ec into XRPLF:develop Oct 6, 2023
15 checks passed
@florent-uzio florent-uzio deleted the compression branch October 6, 2023 16:11
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@florent-uzio @sophiax851
docs(rippled-example.cfg): add P2P link compression (XRPLF#4753)
dd53eb9 
P2P link compression is a feature added in 1.6.0 by XRPLF#3287.

https://xrpl.org/enable-link-compression.html

If the default changes in the future - for example, as currently
proposed by XRPLF#4387 - the comment will be updated at that time.

Fix XRPLF#4656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelliot intelliot intelliot approved these changes

@gregtatcam gregtatcam gregtatcam approved these changes

Assignees
No one assigned
Labels
Documentation README changes, code comments, etc.
Projects
Core Ledger
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florent-uzio @intelliot @gregtatcam