Optimize when to acquire ledgers from the network. #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HowardHinnant
approved these changes
Nov 2, 2023
ximinez
approved these changes
Nov 28, 2023
| * When the following are all true, it is very likely that we will | ||
| * soon validate the ledger ourselves. Therefore, avoid acquiring | ||
| * ledgers from the network if: | ||
| * + Our mode is "full". It is very likely that we will acquire |
There was a problem hiding this comment.
Would it make more sense to say "we will build the ledger" instead of "we will acquire the ledger"?
Particulary avoid acquiring ledgers likely to be produced locally very soon.
mtrippled
added
the
Passed
intelliot
added
Perf Attn Needed
intelliot
added
Perf Test Desired (Optional)
|
@mtrippled to confirm that this should be put on hold for now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4764 +/- ##
===========================================
- Coverage 76.97% 76.96% -0.01%
===========================================
Files 1129 1129
Lines 131916 131932 +16
Branches 39614 39662 +48
===========================================
+ Hits 101537 101542 +5
- Misses 24435 24456 +21
+ Partials 5944 5934 -10 ☔ View full report in Codecov by Sentry. |
ximinez
removed
Passed
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Aug 16, 2024
Particulary avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Aug 17, 2024
Particulary avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Aug 17, 2024
Particulary avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Aug 23, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Aug 23, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 2, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 2, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 2, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 2, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 2, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 3, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 4, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 4, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 4, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 4, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 4, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 4, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 5, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 5, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 5, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 6, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 6, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 6, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 8, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 11, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 11, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 11, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 11, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 11, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 11, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
3 tasks
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 25, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 30, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Oct 15, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Oct 18, 2024
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particulary avoid acquiring ledgers likely to be
produced locally very soon.
High Level Overview of Change
Peer ledger acquisition is expensive. This reduces peer ledger aquisition.
Context of Change
Existing code attempts to acquire ledgers if a validation for a new ledger is received, even if it comes moments before we have created the same ledger through normal consensus processing. A peer only needs to be slightly behind the first validator for this to be triggered. This essentially causes all nodes to have expensive background ledgerData acquisition jobs to be running. The fix is to not try to acquire ledgers that are very likely to be created locally through normal processing.
Type of Change