Revert "Apply transaction batches in periodic intervals (#4504)" #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 002893f. Therefore two files with conflicts in the automated revert: - src/ripple/rpc/impl/RPCHelpers.h and - src/test/rpc/JSONRPC_test.cpp Those files were manually resolved. There is currently no evidence that any problems were introduced by XRPLF#4504. However something is misbehaving on the current state of develop, and pull request XRPLF#4504 was identified as a possible suspect.
|
the revert looks good to me 👍 |
ckeshava
approved these changes
Dec 19, 2023
|
I was slightly perplexed by the Github UI. It displays a different hash of f9e5cc3 for the specified commit in the PR page. But, this hash object does not exist in 
|
|
i see, thanks for the explanation 👍 |
ximinez
approved these changes
Dec 19, 2023
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Jan 27, 2024
…XRPLF#4852) This reverts commit 002893f. There were two files with conflicts in the automated revert: - src/ripple/rpc/impl/RPCHelpers.h and - src/test/rpc/JSONRPC_test.cpp Those files were manually resolved.
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Jan 27, 2024
…XRPLF#4852) This reverts commit 002893f. There were two files with conflicts in the automated revert: - src/ripple/rpc/impl/RPCHelpers.h and - src/test/rpc/JSONRPC_test.cpp Those files were manually resolved.
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
…XRPLF#4852) This reverts commit 002893f. There were two files with conflicts in the automated revert: - src/ripple/rpc/impl/RPCHelpers.h and - src/test/rpc/JSONRPC_test.cpp Those files were manually resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This reverts commit 002893f.
There were two files with conflicts in the automated revert:
Those files were manually resolved.
Context of Change
There is currently no evidence that any problems were introduced by #4504. However something is misbehaving on the current state of develop, and pull request #4504 was identified as a possible suspect.
Type of Change