Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI unit tests need to pass #4871

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Jan 9, 2024

High Level Overview of Change

Disable the Windows CI unit tests "allowed to fail" workaround

Context of Change

The runner hardware was upgraded a little while ago, and the unit tests have been passing.

Type of Change

  • [X ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

Before / After

Before: In Windows CI, the unit tests were allowed to silently fail without causing the whole job to fail. This was because it was more important to ensure no inconsistencies were introduced into the build.

After: In Windows CI, if the unit tests fail, the job will fail.

@ximinez ximinez changed the title Github improved runner hardware - tests pass now Windows CI unit tests need to pass Jan 9, 2024
@ximinez ximinez marked this pull request as ready for review January 9, 2024 01:24
@ximinez ximinez added CI Continuous Integration Functionality Perf impact not expected Change is not expected to improve nor harm performance. labels Jan 9, 2024
@ximinez ximinez added this to the 2.1.0 (Feb 2024) milestone Jan 9, 2024
* upstream/develop:
  WebSocket should only call async_close once (4848)
* upstream/develop:
  Improve lifetime management of ledger objects (`SLE`s) to prevent runaway memory usage: (4822)
@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jan 16, 2024
@ximinez
Copy link
Collaborator Author

ximinez commented Jan 16, 2024

Suggested commit message:

Check for success/failure of Windows CI unit tests (#4871)

* Disable the Windows CI unit tests "allowed to fail" workaround
* The runner hardware was upgraded, and the unit tests have been passing since then.

Note: This is slated for 2.1.0, so do not merge until after 2.0.1 is frozen / released.

* upstream/develop:
  fix: change default send_queue_limit to 500 (4867)
  fix: clang warning about deprecated sprintf usage (4747)
* upstream/develop:
  test: add DeliverMax to more JSONRPC tests (4826)
* upstream/develop:
  test: improve code coverage reporting (4849)
  docs: update help message about unit test-suite pattern matching (4846)
  Revert "Asynchronously write batches to NuDB. (4503)" (4882)
  Set version to 2.0.1-b1
  docs: add Performance type to PR template (4875)
* upstream/develop:
  chore: retry codecov upload (4896)
  docs: fix broken links in docs/build/conan.md (4699)
  Set version to 2.0.1-rc1
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22cdb57) 61.50% compared to head (0906335) 61.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4871      +/-   ##
===========================================
- Coverage    61.50%   61.48%   -0.03%     
===========================================
  Files          797      797              
  Lines        70122    70122              
  Branches     36238    36238              
===========================================
- Hits         43131    43115      -16     
- Misses       19757    19762       +5     
- Partials      7234     7245      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@intelliot
Copy link
Collaborator

Same commit message as above but hard wrapped at 72 characters

Check for success/failure of Windows CI unit tests (#4871)

* Disable the Windows CI unit tests "allowed to fail" workaround.
* The runner hardware was upgraded, and the unit tests have been passing
  since then.

@intelliot intelliot merged commit f9e3658 into XRPLF:develop Feb 1, 2024
17 checks passed
@ximinez ximinez deleted the win_ci_tests branch February 1, 2024 17:57
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
* Disable the Windows CI unit tests "allowed to fail" workaround which
  was previously introduced in XRPLF#4596.
* The runner hardware was upgraded, and the unit tests have been passing
  since then.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Functionality Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Perf impact not expected Change is not expected to improve nor harm performance.
Projects
Status: 🚢 Released in 2.2.0
Development

Successfully merging this pull request may close these issues.

5 participants