Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #4931

Closed
wants to merge 2 commits into from
Closed

Update CONTRIBUTING.md #4931

wants to merge 2 commits into from

Conversation

intelliot
Copy link
Collaborator

High Level Overview of Change

Update and alphabetize "Current Maintainers"

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

N/A

Update and alphabetize "Current Maintainers"
@shortthefomo
Copy link

#4904 seems to already be in a better state?

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.0%. Comparing base (f4da2e3) to head (6974dfc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #4931   +/-   ##
=======================================
  Coverage     71.0%   71.0%           
=======================================
  Files          796     796           
  Lines        66793   66793           
  Branches     10987   10986    -1     
=======================================
+ Hits         47420   47421    +1     
+ Misses       19373   19372    -1     

see 4 files with indirect coverage changes

Impacted file tree graph

@intelliot
Copy link
Collaborator Author

#4904 seems to already be in a better state?

That would be fine; I don't have any preference on which one goes in.

@intelliot
Copy link
Collaborator Author

Superseded by #4904

@intelliot intelliot closed this May 17, 2024
@intelliot intelliot deleted the update-maintainers branch May 17, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants