Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMM Unit tests: rounding down of equal asset deposit LPToken calculation #4982

Merged
merged 12 commits into from
Apr 18, 2024
Merged

AMM Unit tests: rounding down of equal asset deposit LPToken calculation #4982

merged 12 commits into from
Apr 18, 2024

Commits on Apr 5, 2024

  1. AMM Unit tests: rounding down of equal asset deposit LPToken calculation 

    include reference from XLS-30d. Validate the expected deposit sums against XLS-30d spec
    @ckeshava
    ckeshava committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e734403 View commit details
    Browse the repository at this point in the history

  2. simplify the numbers used in unit test

    @ckeshava
    ckeshava committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7542e72 View commit details
    Browse the repository at this point in the history

  3. fix clang format

    @ckeshava
    ckeshava committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2db3500 View commit details
    Browse the repository at this point in the history

  4. Enable all unit tests

    @ckeshava
    ckeshava authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    16a6515 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' of https:/XRPLF/rippled into rd

    @ckeshava
    ckeshava committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    bf1712a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'rd' of https:/ckeshava/rippled into rd

    @ckeshava
    ckeshava committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    015c5cd View commit details
    Browse the repository at this point in the history

  7. Rectify numbers to trigger rounding down

    @ckeshava
    ckeshava authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0d357c9 View commit details
    Browse the repository at this point in the history

  8. remove an inaccurate comment

    @ckeshava
    ckeshava committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    31b8971 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. explanatory comment to indicate the rounding down of LPTokens and amo… 

    …unts
    @ckeshava
    ckeshava committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5302b30 View commit details
    Browse the repository at this point in the history

  2. [FOLD] include an assert check to validate rounding down behavior

    @ckeshava
    ckeshava committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    13244e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge branch 'develop' into rd

    @ximinez
    ximinez authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7e9f708 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into rd

    @ximinez
    ximinez authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8f7dbfb View commit details
    Browse the repository at this point in the history