Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update options documentation #5083

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

thejohnfreeman
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.2%. Comparing base (cad8970) to head (2e51bcb).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5083   +/-   ##
=======================================
  Coverage     76.2%   76.2%           
=======================================
  Files          760     760           
  Lines        61489   61489           
  Branches      8115    8113    -2     
=======================================
+ Hits         46832   46839    +7     
+ Misses       14657   14650    -7     

see 5 files with indirect coverage changes

Impacted file tree graph

BUILD.md Outdated Show resolved Hide resolved
Co-authored-by: Elliot Lee <[email protected]>
@ximinez ximinez self-assigned this Aug 1, 2024
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BUILD.md Outdated
| `coverage` | OFF | Prepare the coverage report. |
| `tests` | ON | Build tests. |
| `unity` | ON | Configure a unity build. |
| `reporting` | OFF | Build the reporting mode feature. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is later removed in the PR that removes reporting mode?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though it will need to be merged with this change after it hits develop.

@thejohnfreeman thejohnfreeman added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 28, 2024
@thejohnfreeman thejohnfreeman merged commit 2f432e8 into XRPLF:develop Aug 28, 2024
20 checks passed
@thejohnfreeman thejohnfreeman deleted the options branch August 28, 2024 22:31
@Bronek Bronek added the Trivial label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants