Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix documentation generation job: #5091

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Aug 3, 2024

High Level Overview of Change

Updates the document generation config to work with the new physical code layout. Adds "doxygen" to list of supported branches to allow for testing and development. Adds titles / H1 to some .md files that don't have them.

See https://ximinez.github.io/rippled/ for what it could look like when merged.

Context of Change

The Build and publish Doxygen documentation job stopped working when e238488
was merged to develop. It removed the src/README.md file. That file was unimportant, but it was referenced by the CMake and Doxygen configs for document generation.

This PR removes references to that file, and generalizes the config to remove most references to individual files.

Finally, because I noticed that several of the links on the Related Pages list, which includes all the .md files, had generic titles, I added titles to those files.

Type of Change

  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

Future Tasks

The Build and publish Doxygen documentation job is currently disabled. It can be reenabled just before this PR is merged.

* Add "doxygen" to list of supported branches to allow for testing and
  development.
* Add titles / H1 to some .md files that don't have them.
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8%. Comparing base (93d8baf) to head (e4c9af7).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5091   +/-   ##
=======================================
  Coverage     74.8%   74.8%           
=======================================
  Files          768     768           
  Lines        63134   63134           
  Branches      8869    8869           
=======================================
+ Hits         47237   47241    +4     
+ Misses       15897   15893    -4     

see 3 files with indirect coverage changes

Impacted file tree graph

@ximinez ximinez added Documentation README changes, code comments, etc. Perf impact not expected Change is not expected to improve nor harm performance. labels Aug 5, 2024
@thejohnfreeman
Copy link
Collaborator

Thank you!

@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 8, 2024
@ximinez ximinez merged commit d9bd75e into XRPLF:develop Aug 15, 2024
19 of 20 checks passed
@ximinez ximinez deleted the pr/doxygen branch August 15, 2024 21:03
vlntb pushed a commit to vlntb/rippled that referenced this pull request Aug 23, 2024
* Add "doxygen" to list of supported branches to allow for testing and
  development.
* Add titles / H1 to some .md files that don't have them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation README changes, code comments, etc. Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Perf impact not expected Change is not expected to improve nor harm performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants