Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf dependencies are missing on the clean machine #5156

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

vlntb
Copy link
Collaborator

@vlntb vlntb commented Oct 15, 2024

Context of Change

This was discovered while configuring a clean Ubuntu machine to run rippled. Two dependencies to support protobuf types are missing: libprotobuf-dev protobuf-compiler.
The update is only relevant for manually configuring the C++ development environment.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1%. Comparing base (63209c2) to head (3e51bbe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5156     +/-   ##
=========================================
- Coverage     76.1%   76.1%   -0.0%     
=========================================
  Files          762     762             
  Lines        61469   61469             
  Branches      8121    8122      +1     
=========================================
- Hits         46807   46803      -4     
- Misses       14662   14666      +4     

see 5 files with indirect coverage changes

Impacted file tree graph

@Bronek Bronek added Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Trivial labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants