Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rippled 1.11.0 changes #1976

Merged
merged 12 commits into from
Jul 5, 2023
Merged

rippled 1.11.0 changes #1976

merged 12 commits into from
Jul 5, 2023

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Jun 24, 2023

- the "strict" parameter is now the default; only addresses are allowed
  in the "account" field now (rippled PR#4404)
- now returns account_flags as a map of booleans (rippled PR#4459)
@github-actions
Copy link

Link check report. 495059 links checked.
1 broken links found:
File: out/transaction-common-fields.html Link: parallel-network.html

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/

Style Report

@tequdev
Copy link
Contributor

tequdev commented Jun 24, 2023

Is it possible to change the Japanese content (*.ja.md) as well, so that it can remain in English?

I think it's better to have the information that new parts are untranslated than to have the content remain old and not updated.

@mDuo13 mDuo13 marked this pull request as ready for review June 27, 2023 00:59
@mDuo13
Copy link
Collaborator Author

mDuo13 commented Jun 27, 2023

Is it possible to change the Japanese content (*.ja.md) as well, so that it can remain in English?

I think it's better to have the information that new parts are untranslated than to have the content remain old and not updated.

I agree that it's better, but it's a lot more work to find the appropriate places to update the Japanese docs every time we make a change. I would rather just mark the pages as needing translation updates and prioritize them.

@github-actions
Copy link

Link check report. 495063 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/

Style Report

1 similar comment
@github-actions
Copy link

Link check report. 495063 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/

Style Report

Comment on lines 222 to 225
| `disallowIncomingCheck` | Boolean | If `true`, the account does not allow others to send [Checks](checks.html) to it. |
| `disallowIncomingNFTokenOffer` | Boolean | If `true`, the account does not allow others to make [NFT buy or sell offers](non-fungible-token-transfers.html) to it. |
| `disallowIncomingPayChan` | Boolean | If `true`, the account does not allow others to make [Payment Channels](payment-channels.html) to it. |
| `disallowIncomingTrustline` | Boolean | If `true`, the account does not allow others to make [trust lines](trust-lines-and-issuing.html) to it. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, these fields are not returned unless the featureDisallowIncoming amendment is enabled.

Copy link
Contributor

@DennisDawson DennisDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some ignorable suggestions just to prove I read the whole thing.


The following fields are deprecated and should not be provided: `ident`, `ledger`.
The following fields are deprecated and should not be provided: `ident`, `ledger`, `strict`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always cringe at should, because it suggests there are times you would use them. Perhaps "The following fields are deprecated." or "The following fields are deprecated and ignored."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ident is ignored, ledger will technically still work but it's more ambiguous than using one of ledger_index/ledger_hash, and passing in a non-default (true) value for strict works but is now the same as the default. (Previously the default, strict=false, meant that you could provide a secret key or something in the account field, which is a bad idea shortcut that was used by automated tests once upon a time.)

So, while there's no reason when you should use them, a case where you would use strict=true is if you were writing code that's backwards compatible with older rippled versions (including forked/branched code running on some test networks/sidechains) but still secure.

@github-actions
Copy link

Link check report. 495066 links checked.
1 broken links found:
File: out/account_currencies.html Link: [Updated in: rippled 1.11.0][]

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/

Style Report

@github-actions
Copy link

Link check report. 495073 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/rippled_1.11.0/

Style Report

Copy link
Contributor

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - great updates!

@mDuo13 mDuo13 merged commit f8c88da into master Jul 5, 2023
@mDuo13 mDuo13 deleted the rippled_1.11.0 branch July 5, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the NetworkID field (Version 1.11.0)
5 participants