Note that fee_ref will be removed if XRPFees is enabled
#2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliot
approved these changes
Oct 3, 2023
content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Elliot Lee <[email protected]>
intelliot
approved these changes
Oct 4, 2023
amarantha-k
reviewed
Oct 9, 2023
content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md
Outdated
Show resolved
Hide resolved
|
Minor suggestion to avoid ambiguity. |
…cription-methods/subscribe.md Co-authored-by: Amarantha Kulkarni <[email protected]>
|
@ximinez - I accepted the suggestion as it made sense to me - but please do let me know if you disagree |
I agree with the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRPLF/rippled#4247 removed the
fee_reffield from the Ledger subscription stream ifXRPFeesis enabled. This is becauseXRPFeesremoves the concept of fee levels from rippled, and that's whatfee_refreturned, so it doesn't make any sense to include anymore.