Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link compression tutorial #881

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Add link compression tutorial #881

merged 2 commits into from
Aug 17, 2020

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Aug 3, 2020

Copy link

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question. Does it make sense to mention that a subset of protocol messages is compressed? We only attempt to compress the following messages: protocol::mtMANIFESTS, protocol::mtENDPOINTS, protocol::mtTRANSACTION, protocol::mtGET_LEDGER, protocol::mtLEDGER_DATA, protocol::mtGET_OBJECTS, protocol::mtVALIDATORLIST. Also, if a message is not compressible, then we send uncompressed message.

To enable link compression on your server, complete the following steps:

### 1. Edit your `rippled`'s config file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the following? Seems weird to add the possessive to rippled, and using "server" is consistent with the other docs.

Edit your rippled server's config file.

# Enable Link Compression

The `rippled` server can save bandwidth by compressing its [peer-to-peer communications](peer-protocol.html), at a cost of greater CPU usage. If you enable link compression, the server automatically compresses communications with peer servers that also have link compression enabled. The server uses uncompressed communications with peers who do not have have link compression enabled or do not support link compression. [New in: rippled 1.6.0][]

Copy link

@ddibble-rip ddibble-rip Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering how much CPU usage would be saved by this. Makes sense to compress bandwidth if you knew this setting is the norm for most other hosts.

Anyway to recast the last sentence? There's also a repeated "have" in the sentence:

The server uses uncompressed communications with peers who do not have have link compression enabled or do not support link compression.

Something like this, maybe?

Peer-to-peer link compression works only with peer servers that support link compression and have link compression enabled. In the absence of either, your server defaults to uncompressed communications with that peer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking about it and I decided the best way to rephrase the sentence was to remove it.

It's implied by the previous sentence and awkwardly long pretty much no matter what, so I think in reality it's more likely to confuse people than it is to help.

Copy link

@ddibble-rip ddibble-rip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Rome,
Just a couple of comments around clarity, and repeated word within a paragraph. Otherwise, looks great.

@mDuo13 mDuo13 merged commit a379f04 into XRPLF:v1.6.0 Aug 17, 2020
@mDuo13 mDuo13 deleted the link_compression branch August 17, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants