test: add integration tests for sidechain transactions

[mvadari]

High Level Overview of Change

Title says it all.

Context of Change

Integration tests for #417. These tests are in a separate PR to make it easier to review and because tests won't pass in CI yet (since the amendment isn't a part of the Docker container yet), and will be merged into the feature branch prior to merging into main. Any bugfixes that were caught by these tests were moved to #417.

Type of Change

• Tests (You added tests for code that already exists, or your new feature included in this PR)

Test Plan

Passes locally when running a version of rippled with the amendment enabled.

[JST5000]

Why is this using a different assert than the rest of the testing framework?

[JST5000]

These variables are a bit hard to read because they all start with a long prefix. I'd recommend simplifying the names by removing that prefix (claim_id_...), and potentially adding a comment near the top for // Claim ID Data so that the variable's purposes can be more easily sight-read.

I've been having this problem a lot when reviewing sidechain PRs (since there's a lot of XChain... variables as well - so I'd recommend trying to apply this change more broadly.

Suggested change

	claim_id_hash = (
	claim_id_response.result.get("tx_json") or claim_id_response.result
	)["hash"]
	claim_id_tx_response = await client.request(Tx(transaction=claim_id_hash))
	nodes = claim_id_tx_response.result["meta"]["AffectedNodes"]
	created_nodes = [
	node["CreatedNode"] for node in nodes if "CreatedNode" in node.keys()
	]
	claim_ids_ledger_entries = [
	node
	for node in created_nodes
	if node["LedgerEntryType"] == "XChainOwnedClaimID"
	]
	assert len(claim_ids_ledger_entries) == 1, len(claim_ids_ledger_entries)
	xchain_claim_id = claim_ids_ledger_entries[0]["NewFields"]["XChainClaimID"]
	hash = (
	claim_id_response.result.get("tx_json") or claim_id_response.result
	)["hash"]
	tx_response = await client.request(Tx(transaction=hash))
	nodes = tx_response.result["meta"]["AffectedNodes"]
	created_nodes = [
	node["CreatedNode"] for node in nodes if "CreatedNode" in node.keys()
	]
	ledger_entries = [
	node
	for node in created_nodes
	if node["LedgerEntryType"] == "XChainOwnedClaimID"
	]
	assert len(ledger_entries) == 1, len(ledger_entries)
	xchain_claim_id = ledger_entries[0]["NewFields"]["XChainClaimID"]

[mvadari]

I'd rather keep the variables more descriptive.

[JST5000]

LGTM - Just a variable name style comment to take or leave :)

[khancode]

LGTM