Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the missing AMMDeposit flag TF_TWO_ASSET_IF_EMPTY #696

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

ckeshava
Copy link
Collaborator

High Level Overview of Change

Sister PR from XRPLF/xrpl.js#2667
Fixes XRPLF/xrpl.js#2666

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

I don't know enough about this particular flag to write tests. Please let me know if you have ideas

@ckeshava
Copy link
Collaborator Author

@khancode @pdp2121 can you please review this PR?

@ckeshava ckeshava merged commit 9879092 into main Mar 22, 2024
21 checks passed
@ckeshava ckeshava deleted the ammFlags branch March 22, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfTwoAssetIfEmpty flag is missing
3 participants